Bug 112290 - [BlackBerry] Do not do scroll position adjustment if selecting in a subframe
Summary: [BlackBerry] Do not do scroll position adjustment if selecting in a subframe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-13 14:24 PDT by Iris Wu
Modified: 2013-03-13 15:33 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.46 KB, patch)
2013-03-13 14:36 PDT, Iris Wu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Iris Wu 2013-03-13 14:24:23 PDT
In SelectionHandler scroll position adjustment animation is based on main frame. If selecting in a subframe, don't do animation.
Comment 1 Iris Wu 2013-03-13 14:36:31 PDT
Created attachment 192996 [details]
Patch
Comment 2 Rob Buis 2013-03-13 14:47:48 PDT
Comment on attachment 192996 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2013-03-13 15:33:04 PDT
Comment on attachment 192996 [details]
Patch

Clearing flags on attachment: 192996

Committed r145763: <http://trac.webkit.org/changeset/145763>
Comment 4 WebKit Review Bot 2013-03-13 15:33:07 PDT
All reviewed patches have been landed.  Closing bug.