Bug 112289 - [WK2][EFL] Get rid of WebPageProxy::viewWidget() method
Summary: [WK2][EFL] Get rid of WebPageProxy::viewWidget() method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-13 13:54 PDT by Mikhail Pozdnyakov
Modified: 2013-03-15 00:15 PDT (History)
6 users (show)

See Also:

Attachments
patch (5.85 KB, patch)
2013-03-13 14:05 PDT, Mikhail Pozdnyakov 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
run EWS (6.73 KB, patch)
2013-03-14 11:49 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
patch v2 (6.63 KB, patch)
2013-03-14 13:18 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2013-03-13 13:54:58 PDT 
SSIA. Heaving this method inside web page is broken design: web page should not be aware of platform-specific view.
Comment 1 Mikhail Pozdnyakov 2013-03-13 14:05:15 PDT 
Created attachment 192990 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2013-03-13 14:31:47 PDT 
Comment on attachment 192990 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192990&action=review

nice

> Source/WebKit2/ChangeLog:9
> +        Having viewWidget() method inside web page is broken design: web
> +        page should not be aware of platform-specific view.

I would refrase that.
Comment 3 EFL EWS Bot 2013-03-13 16:29:14 PDT 
Comment on attachment 192990 [details]
patch

Attachment 192990 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17199068
Comment 4 Mikhail Pozdnyakov 2013-03-14 08:31:50 PDT 
(In reply to comment #3)
> (From update of attachment 192990 [details])
> Attachment 192990 [details] did not pass efl-ews (efl):
> Output: http://webkit-commit-queue.appspot.com/results/17199068

Weird.. I cannot reproduce it locally.
Comment 5 Gyuyoung Kim 2013-03-14 09:34:43 PDT 
Comment on attachment 192990 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192990&action=review

> Source/WebKit2/PlatformEfl.cmake:-85
> -    UIProcess/cairo/BackingStoreCairo.cpp

To help you, I can reproduce build error when I build WebKit EFL with this patch locally. It looks these build error comes from removing this file.

../../lib/libewebkit2.so.0.1.0: undefined reference to `WebKit::BackingStore::paint(_cairo*, WebCore::IntRect const&)'
../../lib/libewebkit2.so.0.1.0: undefined reference to `WebKit::BackingStore::incorporateUpdate(WebKit::ShareableBitmap*, WebKit::UpdateInfo const&)'
Comment 6 Mikhail Pozdnyakov 2013-03-14 11:49:06 PDT 
Created attachment 193165 [details]
run EWS
Comment 7 Mikhail Pozdnyakov 2013-03-14 13:18:10 PDT 
Created attachment 193176 [details]
patch v2

fix build: do not exclude BackingStoreCairo.cpp from cmake.
Comment 8 Alexey Proskuryakov 2013-03-14 13:26:39 PDT 
Comment on attachment 193176 [details]
patch v2

r=me (largely taking in consideration Kenneth's approval).
Comment 9 Kenneth Rohde Christiansen 2013-03-14 15:47:47 PDT 
Great!
Comment 10 WebKit Review Bot 2013-03-15 00:15:43 PDT 
Comment on attachment 193176 [details]
patch v2

Clearing flags on attachment: 193176

Committed r145880: <http://trac.webkit.org/changeset/145880>
Comment 11 WebKit Review Bot 2013-03-15 00:15:49 PDT 
All reviewed patches have been landed.  Closing bug.