RESOLVED FIXED 112277
Threaded HTML Parser is missing feature define flags in all but Chromium port's build files 
https://bugs.webkit.org/show_bug.cgi?id=112277
Summary Threaded HTML Parser is missing feature define flags in all but Chromium port...
Ryosuke Niwa
Reported 2013-03-13 12:46:16 PDT
Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
Attachments
Adds the feature flag everywhere (33.62 KB, patch)
2013-03-13 12:47 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed a type in FeatureList.pm (33.62 KB, patch)
2013-03-13 13:00 PDT, Ryosuke Niwa 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-03-13 12:47:20 PDT
Created attachment 192967 [details] Adds the feature flag everywhere
Early Warning System Bot
Comment 2 2013-03-13 12:55:58 PDT
Comment on attachment 192967 [details] Adds the feature flag everywhere Attachment 192967 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17147211
WebKit Review Bot
Comment 3 2013-03-13 12:56:00 PDT
Comment on attachment 192967 [details] Adds the feature flag everywhere Attachment 192967 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17179101
Ryosuke Niwa
Comment 4 2013-03-13 13:00:25 PDT
Created attachment 192973 [details] Fixed a type in FeatureList.pm
Adam Barth
Comment 5 2013-03-13 13:09:49 PDT
Comment on attachment 192973 [details] Fixed a type in FeatureList.pm View in context: https://bugs.webkit.org/attachment.cgi?id=192973&action=review > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:392 > PerformEnvironmentSet="true" Do you intend to enable it by default?
Eric Seidel (no email)
Comment 6 2013-03-13 13:27:09 PDT
Thanks!
Ryosuke Niwa
Comment 7 2013-03-13 13:56:03 PDT
(In reply to comment #5) > (From update of attachment 192973 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192973&action=review > > > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:392 > > PerformEnvironmentSet="true" > > Do you intend to enable it by default? I thought this flag just says to put this flag as an environmental variable?
Adam Barth
Comment 8 2013-03-13 14:09:46 PDT
Oh, could be. I don't use visual studio much.
Ryosuke Niwa
Comment 9 2013-03-13 16:00:04 PDT
Committed r145768: <http://trac.webkit.org/changeset/145768>
Note You need to log in before you can comment on or make changes to this bug.