Bug 112277 - Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
Summary: Threaded HTML Parser is missing feature define flags in all but Chromium port...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-13 12:46 PDT by Ryosuke Niwa
Modified: 2013-03-13 16:00 PDT (History)
13 users (show)

See Also:

Attachments
Adds the feature flag everywhere (33.62 KB, patch)
2013-03-13 12:47 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed a type in FeatureList.pm (33.62 KB, patch)
2013-03-13 13:00 PDT, Ryosuke Niwa 		abarth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-03-13 12:46:16 PDT 
Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
Comment 1 Ryosuke Niwa 2013-03-13 12:47:20 PDT 
Created attachment 192967 [details]
Adds the feature flag everywhere
Comment 2 Early Warning System Bot 2013-03-13 12:55:58 PDT 
Comment on attachment 192967 [details]
Adds the feature flag everywhere

Attachment 192967 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17147211
Comment 3 WebKit Review Bot 2013-03-13 12:56:00 PDT 
Comment on attachment 192967 [details]
Adds the feature flag everywhere

Attachment 192967 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17179101
Comment 4 Ryosuke Niwa 2013-03-13 13:00:25 PDT 
Created attachment 192973 [details]
Fixed a type in FeatureList.pm
Comment 5 Adam Barth 2013-03-13 13:09:49 PDT 
Comment on attachment 192973 [details]
Fixed a type in FeatureList.pm

View in context: https://bugs.webkit.org/attachment.cgi?id=192973&action=review

> WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:392
>  		PerformEnvironmentSet="true"

Do you intend to enable it by default?
Comment 6 Eric Seidel (no email) 2013-03-13 13:27:09 PDT 
Thanks!
Comment 7 Ryosuke Niwa 2013-03-13 13:56:03 PDT 
(In reply to comment #5)
> (From update of attachment 192973 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192973&action=review
> 
> > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:392
> >  		PerformEnvironmentSet="true"
> 
> Do you intend to enable it by default?

I thought this flag just says to put this flag as an environmental variable?
Comment 8 Adam Barth 2013-03-13 14:09:46 PDT 
Oh, could be.  I don't use visual studio much.
Comment 9 Ryosuke Niwa 2013-03-13 16:00:04 PDT 
Committed r145768: <http://trac.webkit.org/changeset/145768>