Bug 112272 - [GTK] Missing atk in install-dependencies script
Summary: [GTK] Missing atk in install-dependencies script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-13 11:15 PDT by Claudio Saavedra
Modified: 2013-03-21 08:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2013-03-13 11:16 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Patch (1.25 KB, patch)
2013-03-21 06:53 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2013-03-13 11:15:35 PDT 
[GTK] Missing atk dependency for gtk in jhbuild moduleset
Comment 1 Claudio Saavedra 2013-03-13 11:16:36 PDT 
Created attachment 192950 [details]
Patch
Comment 2 Martin Robinson 2013-03-13 11:45:51 PDT 
(In reply to comment #1)
> Created an attachment (id=192950) [details]
> Patch

The criteria for being in non-optional moduleset isn't whether or not there is a hard dependency, but whether or not a particular package requires a particular version to pass layout tests.
Comment 3 Claudio Saavedra 2013-03-13 11:51:36 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=192950) [details] [details]
> > Patch
> 
> The criteria for being in non-optional moduleset isn't whether or not there is a hard dependency, but whether or not a particular package requires a particular version to pass layout tests.

I think jhbuild has a mechanism to suggest installing packages from the distro. As it is now you can't use update-webkitgtk-libs to bootstrap webkit.
Comment 4 Martin Robinson 2013-03-13 13:02:23 PDT 
Comment on attachment 192950 [details]
Patch

atk should go into install-dependencies instead of here. Only dependencies that require an exact version for layout tests to pass should go into the jhbuild moduleset.
Comment 5 Claudio Saavedra 2013-03-21 06:53:59 PDT 
Created attachment 194252 [details]
Patch
Comment 6 WebKit Review Bot 2013-03-21 08:32:10 PDT 
Comment on attachment 194252 [details]
Patch

Clearing flags on attachment: 194252

Committed r146472: <http://trac.webkit.org/changeset/146472>
Comment 7 WebKit Review Bot 2013-03-21 08:32:14 PDT 
All reviewed patches have been landed.  Closing bug.