Bug 112271 – Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Antoine Quint]

Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation

[Antoine Quint]

Created attachment 192949 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/13412044>

[Tim Horton]

Comment on attachment 192949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192949&action=review

> Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158
> +    m_fadeAnimationTimer.stop();

Should you reset m_fractionFadedIn to ... something?

[Antoine Quint]

(In reply to comment #3)
> (From update of attachment 192949 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192949&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158
> > +    m_fadeAnimationTimer.stop();
> 
> Should you reset m_fractionFadedIn to ... something?

m_fractionFadedIn needs to be reset to 1.0 I would say.

[Antoine Quint]

Created attachment 192951 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 192951 [details]
Patch for landing

Clearing flags on attachment: 192951

Committed r145731: <http://trac.webkit.org/changeset/145731>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.