WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
112271
Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation
https://bugs.webkit.org/show_bug.cgi?id=112271
Summary
Calling WebInspectorClient::highlight() during a fade-out animation of the Pa...
Antoine Quint
Reported
2013-03-13 11:09:28 PDT
Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation
Attachments
Patch
(3.24 KB, patch)
2013-03-13 11:13 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch for landing
(3.16 KB, patch)
2013-03-13 11:25 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2013-03-13 11:13:45 PDT
Created
attachment 192949
[details]
Patch
Radar WebKit Bug Importer
Comment 2
2013-03-13 11:14:25 PDT
<
rdar://problem/13412044
>
Tim Horton
Comment 3
2013-03-13 11:16:47 PDT
Comment on
attachment 192949
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=192949&action=review
> Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158 > + m_fadeAnimationTimer.stop();
Should you reset m_fractionFadedIn to ... something?
Antoine Quint
Comment 4
2013-03-13 11:19:37 PDT
(In reply to
comment #3
)
> (From update of
attachment 192949
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=192949&action=review
> > > Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158 > > + m_fadeAnimationTimer.stop(); > > Should you reset m_fractionFadedIn to ... something?
m_fractionFadedIn needs to be reset to 1.0 I would say.
Antoine Quint
Comment 5
2013-03-13 11:25:05 PDT
Created
attachment 192951
[details]
Patch for landing
WebKit Review Bot
Comment 6
2013-03-13 11:49:46 PDT
Comment on
attachment 192951
[details]
Patch for landing Clearing flags on attachment: 192951 Committed
r145731
: <
http://trac.webkit.org/changeset/145731
>
WebKit Review Bot
Comment 7
2013-03-13 11:49:49 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug