Bug 112271 - Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation
Summary: Calling WebInspectorClient::highlight() during a fade-out animation of the Pa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-13 11:09 PDT by Antoine Quint
Modified: 2013-03-13 11:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2013-03-13 11:13 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (3.16 KB, patch)
2013-03-13 11:25 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2013-03-13 11:09:28 PDT 
Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation
Comment 1 Antoine Quint 2013-03-13 11:13:45 PDT 
Created attachment 192949 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2013-03-13 11:14:25 PDT 
<rdar://problem/13412044>
Comment 3 Tim Horton 2013-03-13 11:16:47 PDT 
Comment on attachment 192949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192949&action=review

> Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158
> +    m_fadeAnimationTimer.stop();

Should you reset m_fractionFadedIn to ... something?
Comment 4 Antoine Quint 2013-03-13 11:19:37 PDT 
(In reply to comment #3)
> (From update of attachment 192949 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192949&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158
> > +    m_fadeAnimationTimer.stop();
> 
> Should you reset m_fractionFadedIn to ... something?

m_fractionFadedIn needs to be reset to 1.0 I would say.
Comment 5 Antoine Quint 2013-03-13 11:25:05 PDT 
Created attachment 192951 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-03-13 11:49:46 PDT 
Comment on attachment 192951 [details]
Patch for landing

Clearing flags on attachment: 192951

Committed r145731: <http://trac.webkit.org/changeset/145731>
Comment 7 WebKit Review Bot 2013-03-13 11:49:49 PDT 
All reviewed patches have been landed.  Closing bug.