RESOLVED FIXED 112267
[GTK] Build fixes after 145552 
https://bugs.webkit.org/show_bug.cgi?id=112267
Summary [GTK] Build fixes after 145552
Zan Dobersek
Reported 2013-03-13 09:22:04 PDT
[GTK] Build fixes after 145552
Attachments
Patch (3.19 KB, patch)
2013-03-13 09:25 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-03-13 09:25:07 PDT
Created attachment 192935 [details] Patch
Zan Dobersek
Comment 2 2013-03-13 09:26:38 PDT
I apologize for letting these mistakes creeping into the patch in the first place, though I still can't wrap my head around how building with the gold linker actually worked (the issue was discovered when using the GNU linker).
Gustavo Noronha (kov)
Comment 3 2013-03-13 10:53:01 PDT
Comment on attachment 192935 [details] Patch That happens to me all the time - things working with gold and not with the old ld, I think gold is less strict about its checking of unresolved symbols, and I assume that is one of the reasons why it's faster.
Gustavo Noronha (kov)
Comment 4 2013-03-13 12:42:12 PDT
Comment on attachment 192935 [details] Patch I'll take the liberty of doing cq+ since this is a build fix and people are popping up asking about the problem.
WebKit Review Bot
Comment 5 2013-03-13 12:48:25 PDT
Comment on attachment 192935 [details] Patch Clearing flags on attachment: 192935 Committed r145738: <http://trac.webkit.org/changeset/145738>
WebKit Review Bot
Comment 6 2013-03-13 12:48:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.