RESOLVED FIXED 112264
Web Inspector: Flame Chart. Rewrite drawing procedure for better performance. 
https://bugs.webkit.org/show_bug.cgi?id=112264
Summary Web Inspector: Flame Chart. Rewrite drawing procedure for better performance.
Ilya Tikhonovsky
Reported 2013-03-13 09:15:25 PDT
The current implementation is slow and produces garbage. The new one calculates almost everything only once.
Attachments
Patch (14.64 KB, patch)
2013-03-13 09:26 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2013-03-13 09:26:13 PDT
Created attachment 192936 [details] Patch
Yury Semikhatsky
Comment 2 2013-03-14 00:32:57 PDT
Comment on attachment 192936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192936&action=review > Source/WebCore/inspector/front-end/FlameChart.js:87 > + var startTimes = new Float32Array(nodeCount); Does it make any difference compared to new Array(nodeCount) ? > Source/WebCore/inspector/front-end/FlameChart.js:94 > + function appendReversedArray(toArray, fromArray) { style: { on next line.
Ilya Tikhonovsky
Comment 3 2013-03-14 00:40:37 PDT
Committed r145790: <http://trac.webkit.org/changeset/145790>
Note You need to log in before you can comment on or make changes to this bug.