Bug 112260 - [Qt] Port DRT to use TestRunner::dumpAsText()
Summary: [Qt] Port DRT to use TestRunner::dumpAsText()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks: 109677
  Show dependency tree / graph
 
Reported: 2013-03-13 08:01 PDT by Zeno Albisser
Modified: 2013-03-14 03:09 PDT (History)
0 users

See Also:

Attachments
Patch (6.04 KB, patch)
2013-03-13 08:03 PDT, Zeno Albisser 		no flags Details | Formatted Diff | Diff
Patch (6.13 KB, patch)
2013-03-13 08:32 PDT, Zeno Albisser 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2013-03-13 08:01:47 PDT 
[Qt] Port DRT to use TestRunner::dumpAsText()
Comment 1 Zeno Albisser 2013-03-13 08:03:46 PDT 
Created attachment 192923 [details]
Patch
Comment 2 Simon Hausmann 2013-03-13 08:12:11 PDT 
Comment on attachment 192923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192923&action=review

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:994
> -    if (m_dumpPixelsForCurrentTest && m_controller->shouldDumpPixels()) {
> +    if (m_dumpPixelsForCurrentTest) {

Shouldn't this use m_jscController->generatePixelResults() ? What do the other ports do there?
Comment 3 Zeno Albisser 2013-03-13 08:32:34 PDT 
Created attachment 192928 [details]
Patch
Comment 4 Benjamin Poulain 2013-03-13 22:57:48 PDT 
Comment on attachment 192928 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192928&action=review

Looks reasonable.

> Tools/ChangeLog:15
> +            TestRunnerQt::shouldDumpPixels() always returned true
> +            in our case and can therefore be replaced with
> +            TestRunner::generatePixelResults().

I am a little confused by this sentence.
Comment 5 Zeno Albisser 2013-03-14 03:09:41 PDT 
Committed r145800: <http://trac.webkit.org/changeset/145800>