Bug 112255 - [BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
Summary: [BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
URL:
Keywords:
Depends on: 112236
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-13 07:10 PDT by Arvid Nilsson
Modified: 2013-03-15 16:32 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.13 KB, patch)
2013-03-13 07:22 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Patch (8.21 KB, patch)
2013-03-13 07:27 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2013-03-13 07:10:39 PDT 
Add a new WebOverlay method to expose the LayerCompositingThread::drawRect().

The patch for this bug partly overlaps with the patch for https://bugs.webkit.org/show_bug.cgi?id=112236, bug whichever one lands last will have to adapt I guess.
Comment 1 Arvid Nilsson 2013-03-13 07:11:51 PDT 
Actually, the way the diff turned out, ideally https://bugs.webkit.org/show_bug.cgi?id=112236 should be landed first, to make public the toWebKitWindowCoordinates() method.
Comment 2 Arvid Nilsson 2013-03-13 07:22:27 PDT 
Created attachment 192918 [details]
Patch
Comment 3 Arvid Nilsson 2013-03-13 07:27:50 PDT 
Created attachment 192919 [details]
Patch
Comment 4 Arvid Nilsson 2013-03-13 07:29:04 PDT 
(In reply to comment #3)
> Created an attachment (id=192919) [details]
> Patch

I forgot to credit Yongxin as internal reviewer, in the first patch.
Comment 5 Jakob Petsovits 2013-03-13 09:12:52 PDT 
Comment on attachment 192919 [details]
Patch

Very straightforward, looks good to me.
Comment 6 Rob Buis 2013-03-13 10:19:28 PDT 
Comment on attachment 192919 [details]
Patch

Ok.
Comment 7 WebKit Review Bot 2013-03-15 16:32:24 PDT 
Comment on attachment 192919 [details]
Patch

Clearing flags on attachment: 192919

Committed r145962: <http://trac.webkit.org/changeset/145962>
Comment 8 WebKit Review Bot 2013-03-15 16:32:27 PDT 
All reviewed patches have been landed.  Closing bug.