Bug 112252 - Web Inspector: get rid of hiddenPanels filter
Summary: Web Inspector: get rid of hiddenPanels filter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-13 06:07 PDT by Pavel Feldman
Modified: 2013-03-13 07:20 PDT (History)
14 users (show)

See Also:

Attachments
Patch (21.75 KB, patch)
2013-03-13 06:10 PDT, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2013-03-13 06:07:10 PDT 
Things are now filtered based on capabilities.
Comment 1 Pavel Feldman 2013-03-13 06:10:08 PDT 
Created attachment 192910 [details]
Patch
Comment 2 Timothy Hatcher 2013-03-13 06:25:25 PDT 
Comment on attachment 192910 [details]
Patch

FWIW, this was not added for compatibility reasons. It was added to give WebKit clients (non-browsers) control over what panels to show (hide). I don't think anyone has been using it for a while though, so it is fine to remove. We don't honor it in Safari's Web Inspector either.
Comment 3 Pavel Feldman 2013-03-13 06:37:57 PDT 
I actually added it back in 2009 with your blessing :) Since then we upstreamed our work and aligned things. I meant to say that similar things (timeline, etc.) should be controlled using capabilities.
Comment 4 Pavel Feldman 2013-03-13 07:20:00 PDT 
Committed r145717: <http://trac.webkit.org/changeset/145717>