Bug 112249 - [WK2][Qt] Remove direct references to WK2 internals from QtWebPagePolicyClient.
Summary: [WK2][Qt] Remove direct references to WK2 internals from QtWebPagePolicyClient.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Brüning
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-13 05:06 PDT by Michael Brüning
Modified: 2014-02-03 03:25 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.89 KB, patch)
2013-03-13 05:09 PDT, Michael Brüning 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Brüning 2013-03-13 05:06:57 PDT 
[WK2][Qt] Remove direct references to WK2 internals from QtWebPagePolicyClient.
Comment 1 Michael Brüning 2013-03-13 05:09:47 PDT 
Created attachment 192903 [details]
Patch
Comment 2 Simon Hausmann 2013-03-13 06:23:28 PDT 
Comment on attachment 192903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192903&action=review

> Source/WebKit2/UIProcess/qt/QtWebPagePolicyClient.cpp:137
> +    QString mimeType = adoptToQString(WKURLResponseCopyMIMEType(response)).toLower();
> +    bool canShowMIMEType = WKFrameCanShowMIMEType(frame, adoptWK(WKStringCreateWithQString(mimeType)).get());

Hm, so this creates an intermediate QString just in order to call lower. I wonder if it would be better to make WKFrameCanShowMIMEType do the makeLower() inside and then allow us to pass the WKStringRef and avoid the QString conversion?
Comment 3 Michael Brüning 2013-03-18 03:22:08 PDT 
I checked and it seems that if we want to do fix this for good, we should do it in MIMETypeRegistry in WebCore.
Comment 4 Anders Carlsson 2013-10-02 21:25:02 PDT 
Comment on attachment 192903 [details]
Patch

Qt has been removed, clearing review flags.
Comment 5 Jocelyn Turcotte 2014-02-03 03:25:20 PST 
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.