Bug 112221 - [chromium] Make zoom filter independent of the layer size.
Summary: [chromium] Make zoom filter independent of the layer size.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 18:49 PDT by Dana Jansens
Modified: 2013-04-08 17:00 PDT (History)
12 users (show)

See Also:


Attachments
Patch (6.42 KB, patch)
2013-03-12 18:51 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (6.55 KB, patch)
2013-03-12 18:52 PDT, Dana Jansens
senorblanco: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (6.57 KB, patch)
2013-03-14 11:41 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2013-03-12 18:49:01 PDT
[chromium] Make zoom filter independent of the layer size.
Comment 1 Dana Jansens 2013-03-12 18:51:03 PDT
This makes the zoom filter independent of the layer size. You just give a zoom amount and an inset, and the actual width/height computation is done based on the texture size being filtered.

I think since we have no tests or production using the zoom filter yet (right?) I could maybe skip one round of patches and just put a #define in this patch. On the chromium side, I'll just #ifndef the same thing around all the zoom code, basically disabling it temporarily until webkit rolls with this patch.

Is that okay?
Comment 2 Dana Jansens 2013-03-12 18:51:32 PDT
Created attachment 192852 [details]
Patch
Comment 3 Dana Jansens 2013-03-12 18:52:23 PDT
Created attachment 192853 [details]
Patch
Comment 4 WebKit Review Bot 2013-03-12 18:55:14 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 WebKit Review Bot 2013-03-12 19:00:42 PDT
Comment on attachment 192853 [details]
Patch

Attachment 192853 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17139191
Comment 6 WebKit Review Bot 2013-03-12 19:01:09 PDT
Comment on attachment 192853 [details]
Patch

Attachment 192853 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17118095
Comment 7 Peter Beverloo (cr-android ews) 2013-03-12 19:09:19 PDT
Comment on attachment 192853 [details]
Patch

Attachment 192853 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17036677
Comment 8 Dana Jansens 2013-03-12 19:17:28 PDT
I added rect.h to render_pass.h in https://codereview.chromium.org/12816002/ to appease the build errors here:
../../Source/WebKit/chromium/cc/render_pass.h:74: error: 'gfx::Rect' has not been declared
Comment 9 Zachary Kuznia 2013-03-13 01:47:02 PDT
(In reply to comment #1)
> This makes the zoom filter independent of the layer size. You just give a zoom amount and an inset, and the actual width/height computation is done based on the texture size being filtered.
> 
> I think since we have no tests or production using the zoom filter yet (right?) I could maybe skip one round of patches and just put a #define in this patch. On the chromium side, I'll just #ifndef the same thing around all the zoom code, basically disabling it temporarily until webkit rolls with this patch.
> 
> Is that okay?

Sounds good to me.
Comment 10 Stephen White 2013-03-13 08:29:58 PDT
Comment on attachment 192853 [details]
Patch

Seems a little strange that the offset is an int and not a float, but if Zach is ok with it, I'm ok with it.  r=me
Comment 11 Dana Jansens 2013-03-14 11:41:32 PDT
Created attachment 193163 [details]
Patch

for the bots
Comment 12 WebKit Review Bot 2013-03-14 16:31:48 PDT
Comment on attachment 193163 [details]
Patch

Clearing flags on attachment: 193163

Committed r145855: <http://trac.webkit.org/changeset/145855>