Bug 112221 – [chromium] Make zoom filter independent of the layer size.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Make zoom filter independent of the layer size.

[Dana Jansens]

This makes the zoom filter independent of the layer size. You just give a zoom amount and an inset, and the actual width/height computation is done based on the texture size being filtered.

I think since we have no tests or production using the zoom filter yet (right?) I could maybe skip one round of patches and just put a #define in this patch. On the chromium side, I'll just #ifndef the same thing around all the zoom code, basically disabling it temporarily until webkit rolls with this patch.

Is that okay?

[Dana Jansens]

Created attachment 192852 [details]
Patch

[Dana Jansens]

Created attachment 192853 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 192853 [details]
Patch

Attachment 192853 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17139191

[WebKit Review Bot]

Comment on attachment 192853 [details]
Patch

Attachment 192853 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17118095

[Peter Beverloo (cr-android ews)]

Comment on attachment 192853 [details]
Patch

Attachment 192853 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17036677

[Dana Jansens]

I added rect.h to render_pass.h in https://codereview.chromium.org/12816002/ to appease the build errors here:
../../Source/WebKit/chromium/cc/render_pass.h:74: error: 'gfx::Rect' has not been declared

[Zachary Kuznia]

(In reply to comment #1)
> This makes the zoom filter independent of the layer size. You just give a zoom amount and an inset, and the actual width/height computation is done based on the texture size being filtered.
> 
> I think since we have no tests or production using the zoom filter yet (right?) I could maybe skip one round of patches and just put a #define in this patch. On the chromium side, I'll just #ifndef the same thing around all the zoom code, basically disabling it temporarily until webkit rolls with this patch.
> 
> Is that okay?

Sounds good to me.

[Stephen White]

Comment on attachment 192853 [details]
Patch

Seems a little strange that the offset is an int and not a float, but if Zach is ok with it, I'm ok with it.  r=me

[Dana Jansens]

Created attachment 193163 [details]
Patch

for the bots

[WebKit Review Bot]

Comment on attachment 193163 [details]
Patch

Clearing flags on attachment: 193163

Committed r145855: <http://trac.webkit.org/changeset/145855>