Bug 112210 - [Crash] Touch Events retargeting causes crashes on chrome on android.
Summary: [Crash] Touch Events retargeting causes crashes on chrome on android.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 16:58 PDT by Hayato Ito
Modified: 2013-03-12 20:59 PDT (History)
4 users (show)

See Also:


Attachments
Fix crashes. (3.42 KB, patch)
2013-03-12 17:03 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2013-03-12 16:58:14 PDT
The bug on chromium here:
http://code.google.com/p/chromium/issues/detail?id=181603 (This might be security-restricted).

The possible cause:
http://trac.webkit.org/changeset/144877
Comment 1 Hayato Ito 2013-03-12 17:03:44 PDT
Created attachment 192835 [details]
Fix crashes.
Comment 2 Dimitri Glazkov (Google) 2013-03-12 17:41:25 PDT
Comment on attachment 192835 [details]
Fix crashes.

View in context: https://bugs.webkit.org/attachment.cgi?id=192835&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests - no new functionality.

Don't we need a regression test for a crash?
Comment 3 Hayato Ito 2013-03-12 18:00:55 PDT
Thank you for the review.

(In reply to comment #2)
> (From update of attachment 192835 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192835&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        No new tests - no new functionality.
> 
> Don't we need a regression test for a crash?

Yes, we should. But I could not reproduce it yet.

Could you see the http://code.google.com/p/chromium/issues/detail?id=181603
I added you to cc, so you can see the bug on chromium now and know the detail.

I think this patch does not make things worse. So let me land this.
Comment 4 WebKit Review Bot 2013-03-12 20:53:52 PDT
Comment on attachment 192835 [details]
Fix crashes.

Clearing flags on attachment: 192835

Committed r145677: <http://trac.webkit.org/changeset/145677>
Comment 5 WebKit Review Bot 2013-03-12 20:53:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Hayato Ito 2013-03-12 20:59:45 PDT
For the record, as per discussion on http://code.google.com/p/chromium/issues/detail?id=181603, this patch fixes the crash.

Tough, I am not sure yet why touches(), targetTouches() or changedTouches() will becomes null.
Let me repro that, and hopefully add a regression test in another patch.