Bug 112206 - Primary plugin hit detection needs to run after plugin creation
Summary: Primary plugin hit detection needs to run after plugin creation
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Reported: 2013-03-12 16:28 PDT by Dean Jackson
Modified: 2013-03-12 18:01 PDT (History)
2 users (show)

See Also:

Patch (3.80 KB, patch)
2013-03-12 17:12 PDT, Dean Jackson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-03-12 16:28:55 PDT
We can't always guarantee that the didFinishLoad will happen before the plugins are created. Move the plugin hit detection to a more reliable spot.
Comment 1 Radar WebKit Bug Importer 2013-03-12 16:29:13 PDT
Comment 2 Tim Horton 2013-03-12 16:29:35 PDT
Let's not move it, let's just call it from more than one place.
Comment 3 Tim Horton 2013-03-12 16:30:33 PDT
(it was designed to allow calling it again later (the plan was on-plugin-creation), and will choose a primary snapshotted plugin then if there isn't already one)
Comment 4 Dean Jackson 2013-03-12 17:12:30 PDT
Created attachment 192838 [details]
Comment 5 Dean Jackson 2013-03-12 18:01:34 PDT
Committed r145644: <http://trac.webkit.org/changeset/145644>