Bug 112198 - Add a --build-directory argument to delete-stale-build-files
Summary: Add a --build-directory argument to delete-stale-build-files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 15:20 PDT by Tim Horton
Modified: 2013-03-12 15:41 PDT (History)
2 users (show)

See Also:

Attachments
patch (1.59 KB, patch)
2013-03-12 15:22 PDT, Tim Horton 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-03-12 15:20:07 PDT 
So that unconventional build setups can tell it where to look for build products.
Comment 1 Tim Horton 2013-03-12 15:22:29 PDT 
Created attachment 192824 [details]
patch
Comment 2 Ryosuke Niwa 2013-03-12 15:29:06 PDT 
Comment on attachment 192824 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192824&action=review

> Tools/BuildSlaveSupport/delete-stale-build-files:35
> +    parser.add_option("--build-dir", dest="directory")

Could you instead use --build-directory to match run-webkit-tests?

> Tools/BuildSlaveSupport/delete-stale-build-files:53
> +        directory = options.directory

I would have preferred to call this buildDirectory. If you rename the option and omit "dest", it'll automatically do that.
Comment 3 Tim Horton 2013-03-12 15:41:07 PDT 
http://trac.webkit.org/changeset/145600