RESOLVED FIXED112178
Make CheckedArithmetic slightly more sane 
https://bugs.webkit.org/show_bug.cgi?id=112178
Summary Make CheckedArithmetic slightly more sane
Oliver Hunt
Reported 2013-03-12 12:46:32 PDT
Make CheckedArithmetic slightly more sane
Attachments
Patch (3.42 KB, patch)
2013-03-12 12:49 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-03-12 12:49:15 PDT
Created attachment 192789 [details] Patch
Geoffrey Garen
Comment 2 2013-03-12 12:54:54 PDT
Comment on attachment 192789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192789&action=review r=me > Source/WTF/wtf/CheckedArithmetic.h:73 > + HasOverflowed, > + Safe I think this would be clearer if the two states were called "DidOverflow" and "DidNotOverflow". Whether something is "safe" is a value judgement this data cannot make.
Oliver Hunt
Comment 3 2013-03-12 14:07:48 PDT
Committed r145580: <http://trac.webkit.org/changeset/145580>
Note You need to log in before you can comment on or make changes to this bug.