Bug 112178 - Make CheckedArithmetic slightly more sane
Summary: Make CheckedArithmetic slightly more sane
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 12:46 PDT by Oliver Hunt
Modified: 2013-03-12 14:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.42 KB, patch)
2013-03-12 12:49 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-03-12 12:46:32 PDT
Make CheckedArithmetic slightly more sane
Comment 1 Oliver Hunt 2013-03-12 12:49:15 PDT
Created attachment 192789 [details]
Patch
Comment 2 Geoffrey Garen 2013-03-12 12:54:54 PDT
Comment on attachment 192789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192789&action=review

r=me

> Source/WTF/wtf/CheckedArithmetic.h:73
> +    HasOverflowed,
> +    Safe

I think this would be clearer if the two states were called "DidOverflow" and "DidNotOverflow". Whether something is "safe" is a value judgement this data cannot make.
Comment 3 Oliver Hunt 2013-03-12 14:07:48 PDT
Committed r145580: <http://trac.webkit.org/changeset/145580>