Bug 112174 - XHTML MP 1.1 and 1.2 give errors for entities
Summary: XHTML MP 1.1 and 1.2 give errors for entities
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Liam Quinn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 11:50 PDT by Liam Quinn
Modified: 2013-03-13 14:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.88 KB, patch)
2013-03-12 12:04 PDT, Liam Quinn 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Liam Quinn 2013-03-12 11:50:45 PDT 
When an XHTML Mobile Profile 1.1 or 1.2 document contains an XHTML entity such as © or  , WebKit's XML parser gives an error. When an XHTML Mobile Profile 1.0 document does the same thing, it works as expected.

The XML parser has a list of public doctypes for which it resolves XHTML entities. This list includes XHTML MP 1.0 but not XHTML MP 1.1 or 1.2. We should treat XHTML MP 1.1 and 1.2 the same as 1.0 in this respect.
Comment 1 Liam Quinn 2013-03-12 12:04:39 PDT 
Created attachment 192782 [details]
Patch
Comment 2 Rob Buis 2013-03-13 13:16:42 PDT 
Comment on attachment 192782 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2013-03-13 13:27:05 PDT 
Comment on attachment 192782 [details]
Patch

Clearing flags on attachment: 192782

Committed r145744: <http://trac.webkit.org/changeset/145744>
Comment 4 WebKit Review Bot 2013-03-13 13:27:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Hausmann 2013-03-13 14:41:29 PDT 
Comment on attachment 192782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192782&action=review

> Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:644
> +        || (publicId == QLatin1String("-//WAPFORUM//DTD XHTML Mobile 1.0//EN")
> +        || (publicId == QLatin1String("-//WAPFORUM//DTD XHTML Mobile 1.1//EN")

This part broke the Qt build. The line starts with an opening parentheses, the next opening parentheses is the one after QLatin1String but then there's only one closing parentheses.
Comment 6 Simon Hausmann 2013-03-13 14:46:17 PDT 
Prospective fix landed in http://trac.webkit.org/changeset/145756 - hope it works
Comment 7 Liam Quinn 2013-03-13 14:50:29 PDT 
(In reply to comment #6)
> Prospective fix landed in http://trac.webkit.org/changeset/145756 - hope it works

Thanks Simon--that change looks fine. I'm sorry for breaking the build.