Bug 112172 – Web Inspector: do not aggregate non-main thread timeline events, handle them a generic fashion

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

This removes the logic to aggregate rasterize events in timeline agent and instead sends them, along with potential nested events, to front-end, similar to how main thread events are handled. These are later supposed to be collated with front-end event collation logic from bug 112168.

[Andrey Kosyakov]

Created attachment 192777 [details]
Patch

[WebKit Review Bot]

Comment on attachment 192777 [details]
Patch

Attachment 192777 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17173227

[Andrey Kosyakov]

Created attachment 192879 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 192879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192879&action=review

> Source/WebCore/inspector/TimelineTraceEventProcessor.cpp:142
> +    return m_stack.isEmpty() || (m_stack.last().record->getString("type", &lastRecordType) && type == lastRecordType);

return !m_stack.isEmpty() && (m_stack.last().record->getString("type", &lastRecordType) && type == lastRecordType);

> Source/WebCore/inspector/TimelineTraceEventProcessor.cpp:245
> +    ASSERT(!state.rasterizeStartStackLevel);

Looks like rasterizeStartStackLevel could be a boolean (isInRasterize).

[Andrey Kosyakov]

Created attachment 192941 [details]
Patch

[Andrey Kosyakov]

(In reply to comment #4)
> (From update of attachment 192879 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192879&action=review
> 
> > Source/WebCore/inspector/TimelineTraceEventProcessor.cpp:142
> > +    return m_stack.isEmpty() || (m_stack.last().record->getString("type", &lastRecordType) && type == lastRecordType);
> 
> return !m_stack.isEmpty() && (m_stack.last().record->getString("type", &lastRecordType) && type == lastRecordType);

This is written as intended (though may be the method name is unfortunate), not having the top event is considered ok for the purpose of validation -- we hit this case if we started recording in the middle of the event.

> > Source/WebCore/inspector/TimelineTraceEventProcessor.cpp:245
> > +    ASSERT(!state.rasterizeStartStackLevel);
> 
> Looks like rasterizeStartStackLevel could be a boolean (isInRasterize).

Fair, this is atavism of an earlier implementation. Fixed.

[Andrey Kosyakov]

Committed r145809: <http://trac.webkit.org/changeset/145809>