Bug 112169 - [GTK] Enforce the C++11 standard when compiling WebKit2
Summary: [GTK] Enforce the C++11 standard when compiling WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
: 112034 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-03-12 11:07 PDT by Zan Dobersek
Modified: 2013-03-18 01:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.56 KB, patch)
2013-03-12 11:15 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-03-12 11:07:05 PDT 
[GTK] Enforce the C++11 standard when compiling WebKit2
Comment 1 Zan Dobersek 2013-03-12 11:15:35 PDT 
Created attachment 192772 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-12 11:20:48 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Gustavo Noronha (kov) 2013-03-12 12:36:15 PDT 
Comment on attachment 192772 [details]
Patch

What does this gain us? Is the mac wk2 already built like this?
Comment 4 Zan Dobersek 2013-03-12 12:57:49 PDT 
Yes, mac-wk2 already builds WebKit2 in such way, though they are using libc++ as the standard library and enforce the gnu++0x standard. I don't think enforcing c++11 instead of gnu++0x is problematic, at least not at the moment.

I also plan to propose this patch for merging into webkit-2.0 for reasons I've detailed here:
https://bugs.webkit.org/show_bug.cgi?id=109932#c15
Comment 5 Gustavo Noronha (kov) 2013-03-15 14:38:51 PDT 
Comment on attachment 192772 [details]
Patch

OK, then =)
Comment 6 Zan Dobersek 2013-03-15 15:13:46 PDT 
\o/ Thanks!
Comment 7 Zan Dobersek 2013-03-15 15:15:03 PDT 
Comment on attachment 192772 [details]
Patch

Clearing flags on attachment: 192772

Committed r145951: <http://trac.webkit.org/changeset/145951>
Comment 8 Zan Dobersek 2013-03-15 15:15:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Zan Dobersek 2013-03-18 01:01:50 PDT 
*** Bug 112034 has been marked as a duplicate of this bug. ***