WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
112158
[Qt][WK2] Remove the broken QWebDownloadItem lifetime management code
https://bugs.webkit.org/show_bug.cgi?id=112158
Summary
[Qt][WK2] Remove the broken QWebDownloadItem lifetime management code
Jocelyn Turcotte
Reported
2013-03-12 09:13:41 PDT
[Qt][WK2] Remove the broken QWebDownloadItem lifetime management code
Attachments
Patch
(3.01 KB, patch)
2013-03-12 09:18 PDT
,
Jocelyn Turcotte
vestbo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1
2013-03-12 09:18:09 PDT
Created
attachment 192750
[details]
Patch
Simon Hausmann
Comment 2
2013-03-13 14:20:38 PDT
Comment on
attachment 192750
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=192750&action=review
LGTM.
> Source/WebKit2/UIProcess/qt/QtDownloadManager.cpp:111 > + // The objec's ownership is NOT transferable to the handler of this call, and deleting
objec += t :)
Tor Arne Vestbø
Comment 3
2013-03-14 09:46:41 PDT
Comment on
attachment 192750
[details]
Patch lgtm, simons comment applied
Benjamin Poulain
Comment 4
2013-03-19 15:02:46 PDT
Comment on
attachment 192750
[details]
Patch If leaking is fine for you, it is fine for me. Signed off for WebKit2. Don't forget to fix this :)
Jocelyn Turcotte
Comment 5
2014-02-03 03:25:19 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at
https://bugreports.qt-project.org
and add a link to this issue. See
http://qt-project.org/wiki/ReportingBugsInQt
for additional guidelines.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug