Bug 112156 – New context extensions restored improperly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[R S]

When a context is lost and then restored, a new GraphicsContext3D object is created. initializeNewContext() is run to set up the new context, but setupFlags is not run. This means that the extensions are not reloaded and therefore will not work after restoration.

[R S]

Created attachment 192752 [details]
Patch

[R S]

Created attachment 192762 [details]
Patch

[Mike West]

Comment on attachment 192762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192762&action=review

> Source/WebCore/ChangeLog:8
> +        Sets up extensions after new context is created for restoration

Please add a bit more context here: why is this change necessary?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:5825
> +    setupFlags();

Does this produce any web-visible change? If so, it would be excellent to add a test to ensure that the now-correct behavior doesn't regress.

[R S]

Created attachment 192933 [details]
Patch

[R S]

(In reply to comment #3)
> Does this produce any web-visible change? If so, it would be excellent to add a test to ensure that the now-correct behavior doesn't regress.

So far as I can tell it does not produce a web-visible change.

[Rob Buis]

Comment on attachment 192933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192933&action=review

According to mvujovic and achicu this change makes sense, so this just needs the text explanation before it can go in.

> Source/WebCore/ChangeLog:9
> +        Previous extensions set up is lost when context is initially lost.

This needs a line about why the test can't be made.

[R S]

Created attachment 193376 [details]
Patch

[Rob Buis]

Comment on attachment 193376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193376&action=review

Please explain a bit better.

> Source/WebCore/ChangeLog:9
> +        Previous extensions set up is lost when context is initially lost.

Add empty line here.

> Source/WebCore/ChangeLog:10
> +        Cannot create a test as change is not visible from the web.

On irc you gave a more in-depth reason, please combine with this remark.

[R S]

Created attachment 193380 [details]
Patch

[Rob Buis]

Comment on attachment 193380 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 193380 [details]
Patch

Clearing flags on attachment: 193380

Committed r145955: <http://trac.webkit.org/changeset/145955>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.