RESOLVED FIXED 112153
Web Inspector: [CodeMirror] Handle "enter" key in {|} situation 
https://bugs.webkit.org/show_bug.cgi?id=112153
Summary Web Inspector: [CodeMirror] Handle "enter" key in {|} situation
Andrey Lushnikov
Reported 2013-03-12 07:47:07 PDT
Step-by-step: 1. Type following: function foo(a, b){|} 2. Hit enter Expected: function foo(a, b){ | } Actual: function foo(a, b){ |}
Attachments
Patch (2.53 KB, patch)
2013-03-12 07:49 PDT, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (2.61 KB, patch)
2013-03-13 09:01 PDT, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-03-12 07:49:56 PDT
Created attachment 192735 [details] Patch
Vsevolod Vlasov
Comment 2 2013-03-13 05:09:45 PDT
Comment on attachment 192735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192735&action=review > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:493 > + if (line.substr(cursor.ch - 1, 2) === "{}") { You should if the selection range is empty here.
Andrey Lushnikov
Comment 3 2013-03-13 09:01:21 PDT
Created attachment 192931 [details] Patch
WebKit Review Bot
Comment 4 2013-03-13 09:25:59 PDT
Comment on attachment 192931 [details] Patch Clearing flags on attachment: 192931 Committed r145724: <http://trac.webkit.org/changeset/145724>
WebKit Review Bot
Comment 5 2013-03-13 09:26:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.