RESOLVED FIXED 112149
[BlackBerry] SimpleFontData: remove duplicate code 
https://bugs.webkit.org/show_bug.cgi?id=112149
Summary [BlackBerry] SimpleFontData: remove duplicate code
Alberto Garcia
Reported 2013-03-12 07:15:22 PDT
smallCapsFontData() and emphasisMarkFontData() were moved from platform specific files into platform/graphics/SimpleFontData.cpp in r133362, so the BlackBerry port no longer needs its own implementation.
Attachments
Patch (2.56 KB, patch)
2013-03-12 07:16 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-03-12 07:16:43 PDT
Created attachment 192731 [details] Patch
Carlos Garcia Campos
Comment 2 2013-03-13 01:28:43 PDT
Comment on attachment 192731 [details] Patch These methods now return a PassRefPtr, don't you need to adapt the callers too? or this are only called in cross platform code?
Alberto Garcia
Comment 3 2013-03-13 03:50:07 PDT
(In reply to comment #2) > These methods now return a PassRefPtr, don't you need to adapt the > callers too? or this are only called in cross platform code? They're only called from SimpleFontData::variantFontData(), which is in Source/WebCore/platform/graphics/SimpleFontData.h
WebKit Review Bot
Comment 4 2013-03-13 05:40:20 PDT
Comment on attachment 192731 [details] Patch Clearing flags on attachment: 192731 Committed r145706: <http://trac.webkit.org/changeset/145706>
WebKit Review Bot
Comment 5 2013-03-13 05:40:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.