Bug 112149 - [BlackBerry] SimpleFontData: remove duplicate code
Summary: [BlackBerry] SimpleFontData: remove duplicate code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency tree / graph
 
Reported: 2013-03-12 07:15 PDT by Alberto Garcia
Modified: 2013-03-13 05:40 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.56 KB, patch)
2013-03-12 07:16 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-03-12 07:15:22 PDT 
smallCapsFontData() and emphasisMarkFontData() were moved from
platform specific files into platform/graphics/SimpleFontData.cpp in
r133362, so the BlackBerry port no longer needs its own implementation.
Comment 1 Alberto Garcia 2013-03-12 07:16:43 PDT 
Created attachment 192731 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-03-13 01:28:43 PDT 
Comment on attachment 192731 [details]
Patch

These methods now return a PassRefPtr, don't you need to adapt the callers too? or this are only called in cross platform code?
Comment 3 Alberto Garcia 2013-03-13 03:50:07 PDT 
(In reply to comment #2)
> These methods now return a PassRefPtr, don't you need to adapt the
> callers too? or this are only called in cross platform code?

They're only called from SimpleFontData::variantFontData(), which is
in Source/WebCore/platform/graphics/SimpleFontData.h
Comment 4 WebKit Review Bot 2013-03-13 05:40:20 PDT 
Comment on attachment 192731 [details]
Patch

Clearing flags on attachment: 192731

Committed r145706: <http://trac.webkit.org/changeset/145706>
Comment 5 WebKit Review Bot 2013-03-13 05:40:24 PDT 
All reviewed patches have been landed.  Closing bug.