[Qt] Port TestRunner::findString to shared interface
Created attachment 192727 [details] Patch
Created attachment 192728 [details] Patch
Created attachment 192738 [details] Patch
Comment on attachment 192738 [details] Patch Wrong patch :(
Created attachment 192907 [details] Patch
Comment on attachment 192907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192907&action=review > Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:388 > +static DumpRenderTree *s_instance; The compiler should do it but it might be worth explicitely initializing it to 0. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:748 > +bool TestRunner::findString(JSContextRef context, JSStringRef string, JSObjectRef optionsArray) EFL, GTK, chromium and BlackBerry all seem to do the FindOptions matching in TestRunner instead of DumpRenderTreeSupport. It might be worth doing the same while we're there. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:750 > + DumpRenderTree* drt = DumpRenderTree::instance(); It seems like this could be moved right before or into the final return. > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:766 > + Superfluous
Comment on attachment 192907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192907&action=review >> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:388 >> +static DumpRenderTree *s_instance; > > The compiler should do it but it might be worth explicitely initializing it to 0. Done. >> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:748 >> +bool TestRunner::findString(JSContextRef context, JSStringRef string, JSObjectRef optionsArray) > > EFL, GTK, chromium and BlackBerry all seem to do the FindOptions matching in TestRunner instead of DumpRenderTreeSupport. > It might be worth doing the same while we're there. Okay. >> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:750 >> + DumpRenderTree* drt = DumpRenderTree::instance(); > > It seems like this could be moved right before or into the final return. Good idea! done. >> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:766 >> + > > Superfluous Oops :)
Created attachment 192917 [details] Patch
Comment on attachment 192917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192917&action=review LGTM after all :) > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:782 > + This can be removed, I didn't see it earlier
Committed r145719: <http://trac.webkit.org/changeset/145719>