Bug 112143 – [BlackBerry] GraphicsLayer: fix code that was accidentally reverted

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Alberto Garcia]

Several changes were accidentally reverted in r144465 due to the
upstreaming of some new code:

- clearBackgroundColor() and m_contentsLayerHasBackgroundColor had
  been removed in r137798.

- showDebugBorders() had been renamed to isShowingDebugBorder() in
  r133517.

- A new GraphicsLayer::create() overload had been introduced in
  r130185.

[Alberto Garcia]

Created attachment 192724 [details]
Patch

[Rob Buis]

Comment on attachment 192724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192724&action=review

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:-810
> -        return;

Do we need this kind of check for m_layer? Or is it guarenteed to be non-null?

[Alberto Garcia]

(In reply to comment #2)
> (From update of attachment 192724 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192724&action=review
> 
> > Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:-810
> > -        return;
> 
> Do we need this kind of check for m_layer? Or is it guarenteed to be non-null?

m_layer is initialized in the constructor so it's guaranteed to always
have a value.

There's actually a check in GraphicsLayerBlackBerry::willBeDestroyed()
that we should be able to remove:

    if (m_layer)
        m_layer->setOwner(0);

[Rob Buis]

Comment on attachment 192724 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 192724 [details]
Patch

Clearing flags on attachment: 192724

Committed r146499: <http://trac.webkit.org/changeset/146499>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.