Bug 112137 - Web Inspector: Fix JSDocs in TimelinePanel.js
Summary: Web Inspector: Fix JSDocs in TimelinePanel.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 05:24 PDT by Eugene Klyuchnikov
Modified: 2013-03-12 05:47 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2013-03-12 05:26 PDT, Eugene Klyuchnikov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2013-03-12 05:24:04 PDT
Source/WebCore/inspector/front-end/TimelinePanel.js:355: WARNING - actual parameter 1 of WebInspector.createFileSelectorElement does not match formal parameter
found   : function (string): undefined
required: function (File): ?
        this._fileSelectorElement = WebInspector.createFileSelectorElement(this._loadFromFile.bind(this));
                                                                           ^

Source/WebCore/inspector/front-end/TimelinePanel.js:384: WARNING - actual parameter 1 of WebInspector.TimelineModel.prototype.loadFromFile does not match formal parameter
found   : string
required: Blob
        this._model.loadFromFile(fileName, progressIndicator);
                                 ^
Comment 1 Eugene Klyuchnikov 2013-03-12 05:26:30 PDT
Created attachment 192716 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-12 05:47:44 PDT
Comment on attachment 192716 [details]
Patch

Clearing flags on attachment: 192716

Committed r145537: <http://trac.webkit.org/changeset/145537>
Comment 3 WebKit Review Bot 2013-03-12 05:47:48 PDT
All reviewed patches have been landed.  Closing bug.