Bug 112136 - [V8] Move the GetRawTemplate and HasInstance logic from generated bindings to V8PerIsolateData
Summary: [V8] Move the GetRawTemplate and HasInstance logic from generated bindings to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marja Hölttä
URL:
Keywords:
Depends on:
Blocks: 111724
  Show dependency tree / graph
 
Reported: 2013-03-12 05:16 PDT by Marja Hölttä
Modified: 2013-03-12 06:04 PDT (History)
11 users (show)

See Also:

Attachments
Patch (72.97 KB, patch)
2013-03-12 05:25 PDT, Marja Hölttä 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marja Hölttä 2013-03-12 05:16:12 PDT 
When templates for main world and non-main worlds will be separated, HasInstance logic will be a bit ugly: We cannot determine the world type on the fly, because during GC there is no entered context, and HasInstance is called during GC. So we need to check against templates from all the worlds. It's cleaner if that logic is in V8PerIsolateData.
Comment 1 Marja Hölttä 2013-03-12 05:25:29 PDT 
Created attachment 192715 [details]
Patch
Comment 2 Kentaro Hara 2013-03-12 05:31:28 PDT 
Comment on attachment 192715 [details]
Patch

It's anyway a good idea to factor out duplicated logic from auto-generated code to V8Binding.cpp.
Comment 3 WebKit Review Bot 2013-03-12 06:04:20 PDT 
Comment on attachment 192715 [details]
Patch

Clearing flags on attachment: 192715

Committed r145538: <http://trac.webkit.org/changeset/145538>
Comment 4 WebKit Review Bot 2013-03-12 06:04:25 PDT 
All reviewed patches have been landed.  Closing bug.