Bug 112123 – Web Inspector: add html canvas memory details to the native memory overview

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

In addition to cached images we can show memory occupied by HTMLCanvasElements under Image category.

[Yury Semikhatsky]

Created attachment 192687 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 192687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192687&action=review

> Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:82
> +        var canvases = aggregatesByClassName["WebCore::HTMLCanvasElement"];

Please add a blank line above to separate the two types of "images".

> Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:85
> +            return "HTMLCanvasElement";

node.name() above returns something akin to "IMG", which is an HTML name of the tag, as opposed to "HTMLCanvasElement", which is a DOM type name. Inconsistency ensues.

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 192687 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192687&action=review
> 
> > Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:82
> > +        var canvases = aggregatesByClassName["WebCore::HTMLCanvasElement"];
> 
> Please add a blank line above to separate the two types of "images".
> 
Done.

> > Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:85
> > +            return "HTMLCanvasElement";
> 
> node.name() above returns something akin to "IMG", which is an HTML name of the tag, as opposed to "HTMLCanvasElement", which is a DOM type name. Inconsistency ensues.
No, node.name() returns URL of the cached image. We don't have user-friendly name yet so return generic name.

[Yury Semikhatsky]

Committed r145540: <http://trac.webkit.org/changeset/145540>