Bug 112120 - [Chromium] Remove WEBKIT_USING_V8 from the WebKit API
Summary: [Chromium] Remove WEBKIT_USING_V8 from the WebKit API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 02:26 PDT by Adam Barth
Modified: 2013-03-12 16:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.09 KB, patch)
2013-03-12 02:29 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (16.38 KB, patch)
2013-03-12 14:06 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-03-12 02:26:06 PDT 
[Chromium] Remove WEBKIT_USING_V8 from the WebKit API
Comment 1 Adam Barth 2013-03-12 02:29:38 PDT 
Created attachment 192680 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-12 02:31:56 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2013-03-12 03:01:03 PDT 
Comment on attachment 192680 [details]
Patch

Attachment 192680 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17060618
Comment 4 Adam Barth 2013-03-12 03:10:45 PDT 
Comment on attachment 192680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192680&action=review

> Source/WebKit/chromium/public/WebFrame.h:-53
> -namespace v8 {
> -class Context;
> -class Function;
> -class Object;
> -class Value;
> -template <class T> class Handle;
> -template <class T> class Local;
> -}

We may need to keep this forward declaration.  I'll study it in the morning.
Comment 5 Peter Beverloo (cr-android ews) 2013-03-12 03:22:56 PDT 
Comment on attachment 192680 [details]
Patch

Attachment 192680 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17189054
Comment 6 WebKit Review Bot 2013-03-12 03:26:16 PDT 
Comment on attachment 192680 [details]
Patch

Attachment 192680 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17147081
Comment 7 Eric Seidel (no email) 2013-03-12 04:13:23 PDT 
Comment on attachment 192680 [details]
Patch

Wow this stuff is old.
Comment 8 Adam Barth 2013-03-12 14:06:25 PDT 
Created attachment 192802 [details]
Patch
Comment 9 Tony Chang 2013-03-12 14:08:50 PDT 
Comment on attachment 192802 [details]
Patch

Should we also get rid of the #defines in WebCommon.h?
Comment 10 Adam Barth 2013-03-12 14:12:28 PDT 
> Should we also get rid of the #defines in WebCommon.h?

Yes, once https://codereview.chromium.org/12493009/ lands.
Comment 11 WebKit Review Bot 2013-03-12 14:56:30 PDT 
Comment on attachment 192802 [details]
Patch

Clearing flags on attachment: 192802

Committed r145589: <http://trac.webkit.org/changeset/145589>
Comment 12 WebKit Review Bot 2013-03-12 14:56:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Adam Barth 2013-03-12 16:36:02 PDT 
(In reply to comment #10)
> > Should we also get rid of the #defines in WebCommon.h?
> 
> Yes, once https://codereview.chromium.org/12493009/ lands.

Done in bug 112203.