RESOLVED FIXED 112111
Web Inspector: Several inspector tests are flaky beacuse of beforeonload event handler. 
https://bugs.webkit.org/show_bug.cgi?id=112111
Summary Web Inspector: Several inspector tests are flaky beacuse of beforeonload even...
Vsevolod Vlasov
Reported 2013-03-12 00:48:22 PDT
An example of such test: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fdebugger%2Fbreakpoint-manager.html I think this is caused by calling window.addEventListener("beforeunload", onBeforeUnload); without removing such listener in inspector-protocol/page/javascriptDialogEvents.html Patch to follow
Attachments
Patch (2.26 KB, patch)
2013-03-12 00:51 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2013-03-12 00:51:12 PDT
Created attachment 192659 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2013-03-12 00:52:35 PDT
Comment on attachment 192659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192659&action=review > LayoutTests/ChangeLog:9 > + Beforeunload message was updated so that it is possible to find it's source from it. ...its source...
WebKit Review Bot
Comment 3 2013-03-12 01:27:33 PDT
Comment on attachment 192659 [details] Patch Clearing flags on attachment: 192659 Committed r145498: <http://trac.webkit.org/changeset/145498>
WebKit Review Bot
Comment 4 2013-03-12 01:27:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.