Bug 112111 - Web Inspector: Several inspector tests are flaky beacuse of beforeonload event handler.
Summary: Web Inspector: Several inspector tests are flaky beacuse of beforeonload even...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 00:48 PDT by Vsevolod Vlasov
Modified: 2013-03-12 01:27 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.26 KB, patch)
2013-03-12 00:51 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2013-03-12 00:48:22 PDT 
An example of such test: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fdebugger%2Fbreakpoint-manager.html

I think this is caused by calling window.addEventListener("beforeunload", onBeforeUnload); without removing such listener in inspector-protocol/page/javascriptDialogEvents.html

Patch to follow
Comment 1 Vsevolod Vlasov 2013-03-12 00:51:12 PDT 
Created attachment 192659 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2013-03-12 00:52:35 PDT 
Comment on attachment 192659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192659&action=review

> LayoutTests/ChangeLog:9
> +        Beforeunload message was updated so that it is possible to find it's source from it.

...its source...
Comment 3 WebKit Review Bot 2013-03-12 01:27:33 PDT 
Comment on attachment 192659 [details]
Patch

Clearing flags on attachment: 192659

Committed r145498: <http://trac.webkit.org/changeset/145498>
Comment 4 WebKit Review Bot 2013-03-12 01:27:37 PDT 
All reviewed patches have been landed.  Closing bug.