Bug 112090 - [Mac][WK1] Add support for alert() in MiniBrowser.
Summary: [Mac][WK1] Add support for alert() in MiniBrowser.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P5 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-11 18:32 PDT by Andreas Kling
Modified: 2013-03-11 19:40 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2013-03-11 18:36 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (1.52 KB, patch)
2013-03-11 18:38 PDT, Andreas Kling
andersca: review+
Details | Formatted Diff | Diff
Patch for landing (1.47 KB, patch)
2013-03-11 18:56 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-03-11 18:32:56 PDT
>be me
>make simple test page to dump smth from js
>open page in minibrowser to check if behavior differs between WK1/WK2
>mfw alert() is a no-op
Comment 1 Andreas Kling 2013-03-11 18:36:18 PDT
Created attachment 192616 [details]
Patch
Comment 2 Andreas Kling 2013-03-11 18:38:08 PDT
Created attachment 192617 [details]
Patch
Comment 3 Andreas Kling 2013-03-11 18:56:50 PDT
Created attachment 192623 [details]
Patch for landing
Comment 4 WebKit Review Bot 2013-03-11 19:40:14 PDT
Comment on attachment 192623 [details]
Patch for landing

Clearing flags on attachment: 192623

Committed r145468: <http://trac.webkit.org/changeset/145468>
Comment 5 WebKit Review Bot 2013-03-11 19:40:17 PDT
All reviewed patches have been landed.  Closing bug.