RESOLVED FIXED112087
Remove HarfBuzzShaperBase 
https://bugs.webkit.org/show_bug.cgi?id=112087
Summary Remove HarfBuzzShaperBase
Behdad Esfahbod
Reported 2013-03-11 18:05:04 PDT
It was added when there were both harfbuzz.old and harfbuzz-ng shapers in WebCore. Now that the old one is gone HarfBuzzShaperBase should be folded into HarfBuzzShaper.
Attachments
Patch (22.60 KB, patch)
2013-03-25 08:16 PDT, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Patch (22.60 KB, patch)
2013-03-25 23:41 PDT, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2013-03-25 08:16:57 PDT
Created attachment 194862 [details] Patch
Martin Robinson
Comment 2 2013-03-25 08:47:39 PDT
Comment on attachment 194862 [details] Patch Looks reasonable to me, but you didn't mark it for review. Was that intentional. If not, r=me.
Dominik Röttsches (drott)
Comment 3 2013-03-25 08:55:07 PDT
Thanks, Martin. I wanted to see whether the Chromium build succeeds on the bots before r?. But thanks, I gladly accept the r+ now. Will try to get a comment from Chromium folks before landing.
Dominik Röttsches (drott)
Comment 4 2013-03-25 08:59:15 PDT
Bashi, are you okay with this one?
Hajime Morrita
Comment 5 2013-03-25 21:57:02 PDT
Regarding to the green bots, it seems fine for me as a someone in chromium land. I'd rs=me if you put r? there.
Dominik Röttsches (drott)
Comment 6 2013-03-25 23:41:37 PDT
Created attachment 195016 [details] Patch
WebKit Review Bot
Comment 7 2013-03-26 00:54:11 PDT
Comment on attachment 195016 [details] Patch Clearing flags on attachment: 195016 Committed r146855: <http://trac.webkit.org/changeset/146855>
WebKit Review Bot
Comment 8 2013-03-26 00:54:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.