Bug 112086 - FontPlatformDataHarfBuzz::openTypeTable() endianness issue
Summary: FontPlatformDataHarfBuzz::openTypeTable() endianness issue
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-11 18:01 PDT by Behdad Esfahbod
Modified: 2014-05-26 23:15 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Behdad Esfahbod 2013-03-11 18:01:30 PDT 
This code:

PassRefPtr<SharedBuffer> FontPlatformData::openTypeTable(uint32_t table) const 
{ 
    RefPtr<SharedBuffer> buffer; 
 
    SkFontTableTag tag = reverseByteOrder(table); 


It should only reverseByteOrder on little-endian systems, not unconditionally.
Comment 1 Frédéric Wang (:fredw) 2014-05-24 04:15:53 PDT 
I can't find this code. Is it something that was part of Chrome and removed after the Blink fork?
Comment 2 Behdad Esfahbod 2014-05-26 13:48:59 PDT 
(In reply to comment #1)
> I can't find this code. Is it something that was part of Chrome and removed after the Blink fork?

Possible.  The code still exists in Chrome under Skia.
Comment 3 Behdad Esfahbod 2014-05-26 13:51:51 PDT 
Filed here:
https://code.google.com/p/chromium/issues/detail?id=377562

This one should probably be closed.
Comment 4 Frédéric Wang (:fredw) 2014-05-26 23:15:45 PDT 
Thanks, Behdad.