Bug 112077 – add memory sampler to Network Process

• Status: NEW
• Component: WebKit2

[Stephanie Lewis]

Created attachment 192585 [details]
patch

Add memory sampler to the network process and figure out why the sampler is dumping two files per web process.

[WebKit Review Bot]

Attachment 192585 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/NetworkProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcess.h', u'Source/WebKit2/NetworkProcess/NetworkProcess.messages.in', u'Source/WebKit2/UIProcess/WebContext.cpp']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 192585 [details]
patch

Attachment 192585 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17170363

[Stephanie Lewis]

Created attachment 192594 [details]
patch 2

[Brady Eidson]

CC'ing Alexey as I don't fully understand the ramifications of adding a sandbox extension, and doing so without later revoking it.

[Stephanie Lewis]

The extension is revoked when the memory sampler is stopped.  Often not until the process exits however,

void WebMemorySampler::stop() 
{
    ....
    
    if (m_sampleLogSandboxExtension) {
        m_sampleLogSandboxExtension->revoke();
        m_sampleLogSandboxExtension = nullptr;
    }    
}

[Alexey Proskuryakov]

Comment on attachment 192594 [details]
patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=192594&action=review

> Source/WebKit2/UIProcess/WebContext.cpp:996
> +    // WebProcess is called in ProcessDidFinishLoading when we know the PID.

Please reword this to explain what's done with WebProcess there. Also, this would me more visible next to NetworkProcess comment above.

> Source/WebKit2/UIProcess/WebContext.cpp:999
>  void WebContext::stopMemorySampler()

This needs to be updated too.