WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
112073
Gesture events should include AllowShadowContent in hit testing
https://bugs.webkit.org/show_bug.cgi?id=112073
Summary
Gesture events should include AllowShadowContent in hit testing
Christian Biesinger
Reported
2013-03-11 15:33:55 PDT
EventHandler::handleGestureEvent performs a hit test, currently without passing HitTestRequest::AllowShadowContent. It should pass that flag so that web components get the right events
Attachments
AllowShadowContent
(5.62 KB, patch)
2013-03-19 04:11 PDT
,
Hayato Ito
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Hayato Ito
Comment 1
2013-03-11 19:04:46 PDT
Let me take a look. This might be similar to the case of Touch Events, which was fixed in
http://trac.webkit.org/changeset/144877
.
Hayato Ito
Comment 2
2013-03-19 01:38:59 PDT
Hi Christian, Do you have any concrete test case of HTML where users can detect the behavior change between with/without AllowShadowContent? I've just started to investigate. In iOS's WebCore, users can register event listeners for 'gesturestart', 'gesturechange', or 'gesturestop'. But in WebCore, I am afraid that these events are not supported and GestureEvent itself can not be exposed to JavaScript. I appreciate if someone could show us some test cases.
Hayato Ito
Comment 3
2013-03-19 02:38:40 PDT
"gesturetap" event seems to be available. (In reply to
comment #2
)
> Hi Christian, > > Do you have any concrete test case of HTML where users can detect the behavior change between with/without AllowShadowContent? > > I've just started to investigate. In iOS's WebCore, users can register event listeners for 'gesturestart', 'gesturechange', or 'gesturestop'. > But in WebCore, I am afraid that these events are not supported and GestureEvent itself can not be exposed to JavaScript. > > I appreciate if someone could show us some test cases.
Hayato Ito
Comment 4
2013-03-19 04:11:18 PDT
Created
attachment 193784
[details]
AllowShadowContent
WebKit Review Bot
Comment 5
2013-03-20 18:53:57 PDT
Comment on
attachment 193784
[details]
AllowShadowContent Clearing flags on attachment: 193784 Committed
r146427
: <
http://trac.webkit.org/changeset/146427
>
WebKit Review Bot
Comment 6
2013-03-20 18:54:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug