Bug 112068 - Hit testing should use ancestorInThisScope to get the non-shadow ancestor
Summary: Hit testing should use ancestorInThisScope to get the non-shadow ancestor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Christian Biesinger
URL:
Keywords:
Depends on:
Blocks: 110913
  Show dependency tree / graph
 
Reported: 2013-03-11 14:37 PDT by Christian Biesinger
Modified: 2013-03-11 18:10 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.57 KB, patch)
2013-03-11 14:39 PDT, Christian Biesinger 		no flags Details | Formatted Diff | Diff
Patch (3.89 KB, patch)
2013-03-11 14:44 PDT, Christian Biesinger 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Biesinger 2013-03-11 14:37:33 PDT 
Hit testing should use ancestorInThisScope to get the non-shadow ancestor
Comment 1 Christian Biesinger 2013-03-11 14:39:48 PDT 
Created attachment 192561 [details]
Patch
Comment 2 Christian Biesinger 2013-03-11 14:44:19 PDT 
Created attachment 192566 [details]
Patch
Comment 3 Elliott Sprehn 2013-03-11 14:51:12 PDT 
This doesn't look right, you're forcing the hit test to jump all the way out of every shadow back into the main document.

What bug is this trying to fix?
Comment 4 Elliott Sprehn 2013-03-11 15:35:30 PDT 
(In reply to comment #3)
> This doesn't look right, you're forcing the hit test to jump all the way out of every shadow back into the main document.
> 
> What bug is this trying to fix?

Resolved this on IRC, patch looks good, we filed a bug about the cases this breaks.
Comment 5 WebKit Review Bot 2013-03-11 18:10:47 PDT 
Comment on attachment 192566 [details]
Patch

Clearing flags on attachment: 192566

Committed r145448: <http://trac.webkit.org/changeset/145448>
Comment 6 WebKit Review Bot 2013-03-11 18:10:50 PDT 
All reviewed patches have been landed.  Closing bug.