Bug 112059 - Make SegmentedVector Noncopyable
Summary: Make SegmentedVector Noncopyable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-11 13:21 PDT by Oliver Hunt
Modified: 2013-03-11 14:04 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.99 KB, patch)
2013-03-11 13:25 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-03-11 13:21:06 PDT
Make SegmentedVector Noncopyable
Comment 1 Oliver Hunt 2013-03-11 13:25:06 PDT
Created attachment 192538 [details]
Patch
Comment 2 Geoffrey Garen 2013-03-11 13:37:01 PDT
Comment on attachment 192538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192538&action=review

r=me

> Source/JavaScriptCore/bytecompiler/LabelScope.h:79
> +    struct LabelScopeRef {

Let's make this a class.

The idiomatic name for this in WebKit would be "LabelScopePtr".
Comment 3 Geoffrey Garen 2013-03-11 13:37:32 PDT
In future, I think we should just refactor LabelScope to be a true malloc'd, refcounted object, that knows how to notify the byte code generator when it is destroyed.
Comment 4 Oliver Hunt 2013-03-11 14:04:42 PDT
Committed r145401: <http://trac.webkit.org/changeset/145401>