Factor HTMLTreeBuilderSimulator out of BackgroundHTMLParser
Created attachment 192537 [details] Patch
Attachment 192537 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/html/parser/BackgroundHTMLParser.cpp', u'Source/WebCore/html/parser/BackgroundHTMLParser.h', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.cpp', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h']" exit_code: 1 Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:42: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 3 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 192537 [details] Patch This is so much cleaner! This opens up a bunch of interesting possibilities for re-use of this code. :)
Created attachment 192541 [details] Patch for landing
Attachment 192541 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/html/parser/BackgroundHTMLParser.cpp', u'Source/WebCore/html/parser/BackgroundHTMLParser.h', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.cpp', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h']" exit_code: 1 Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:47: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:48: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 192541 [details] Patch for landing Clearing flags on attachment: 192541 Committed r145398: <http://trac.webkit.org/changeset/145398>
All reviewed patches have been landed. Closing bug.
Mac build fix landed in http://trac.webkit.org/changeset/145781. (I forgot to mention it in the change log :()