Bug 112057 - Factor HTMLTreeBuilderSimulator out of BackgroundHTMLParser
Summary: Factor HTMLTreeBuilderSimulator out of BackgroundHTMLParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-03-11 13:06 PDT by Adam Barth
Modified: 2013-03-13 23:49 PDT (History)
8 users (show)

See Also:


Attachments
Patch (25.76 KB, patch)
2013-03-11 13:11 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (25.21 KB, patch)
2013-03-11 13:28 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-03-11 13:06:48 PDT
Factor HTMLTreeBuilderSimulator out of BackgroundHTMLParser
Comment 1 Adam Barth 2013-03-11 13:11:19 PDT
Created attachment 192537 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-11 13:14:33 PDT
Attachment 192537 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/html/parser/BackgroundHTMLParser.cpp', u'Source/WebCore/html/parser/BackgroundHTMLParser.h', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.cpp', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h']" exit_code: 1
Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:42:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:47:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:48:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2013-03-11 13:17:54 PDT
Comment on attachment 192537 [details]
Patch

This is so much cleaner!  This opens up a bunch of interesting possibilities for re-use of this code. :)
Comment 4 Adam Barth 2013-03-11 13:28:58 PDT
Created attachment 192541 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-03-11 13:33:15 PDT
Attachment 192541 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/html/parser/BackgroundHTMLParser.cpp', u'Source/WebCore/html/parser/BackgroundHTMLParser.h', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.cpp', u'Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h']" exit_code: 1
Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:47:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/html/parser/HTMLTreeBuilderSimulator.h:48:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Review Bot 2013-03-11 13:55:58 PDT
Comment on attachment 192541 [details]
Patch for landing

Clearing flags on attachment: 192541

Committed r145398: <http://trac.webkit.org/changeset/145398>
Comment 7 WebKit Review Bot 2013-03-11 13:56:03 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Ryosuke Niwa 2013-03-13 23:49:19 PDT
Mac build fix landed in http://trac.webkit.org/changeset/145781. (I forgot to mention it in the change log :()