Bug 112041 - Web Inspector: [CodeMirror] highlight matching braces
Summary: Web Inspector: [CodeMirror] highlight matching braces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-11 11:03 PDT by Andrey Lushnikov
Modified: 2013-03-12 04:21 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.89 KB, patch)
2013-03-11 11:05 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
highlight matching braces (1.80 KB, image/png)
2013-03-11 11:07 PDT, Andrey Lushnikov 		no flags Details
Patch (9.85 KB, patch)
2013-03-12 02:12 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
border bottom to decorate matching brackets (1.70 KB, image/png)
2013-03-12 02:12 PDT, Andrey Lushnikov 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-03-11 11:03:21 PDT 
Highlight matching braces.
Comment 1 Andrey Lushnikov 2013-03-11 11:05:37 PDT 
Created attachment 192511 [details]
Patch
Comment 2 Andrey Lushnikov 2013-03-11 11:07:02 PDT 
Created attachment 192512 [details]
highlight matching braces
Comment 3 Vsevolod Vlasov 2013-03-12 01:27:21 PDT 
Comment on attachment 192511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192511&action=review

> Source/WebCore/inspector/front-end/cm/cmdevtools.css:36
> +  text-decoration: underline;

Can we use border-bottom to better control its position (this way we can make the border not touch the brace)?
Comment 4 Vsevolod Vlasov 2013-03-12 01:27:25 PDT 
View in context: https://bugs.webkit.org/attachment.cgi?id=192511&action=review

> Source/WebCore/inspector/front-end/cm/cmdevtools.css:36
> +  text-decoration: underline;

Can we use border-bottom to better control its position (this way we can make the border not touch the brace)?
Comment 5 Andrey Lushnikov 2013-03-12 02:12:15 PDT 
Created attachment 192674 [details]
Patch
Comment 6 Andrey Lushnikov 2013-03-12 02:12:35 PDT 
Created attachment 192675 [details]
border bottom to decorate matching brackets
Comment 7 WebKit Review Bot 2013-03-12 04:21:10 PDT 
Comment on attachment 192674 [details]
Patch

Clearing flags on attachment: 192674

Committed r145520: <http://trac.webkit.org/changeset/145520>
Comment 8 WebKit Review Bot 2013-03-12 04:21:13 PDT 
All reviewed patches have been landed.  Closing bug.