Bug 112031 - [EFL] accessibility/placeholder.html is failing
Summary: [EFL] accessibility/placeholder.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111985
  Show dependency tree / graph
 
Reported: 2013-03-11 08:31 PDT by Krzysztof Czech
Modified: 2013-06-03 07:26 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2013-06-03 06:19 PDT, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2013-06-03 06:55 PDT, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2013-03-11 08:31:04 PDT 
accessibility/placeholder.html is failing on efl-wk2.
Comment 1 Krzysztof Czech 2013-06-03 06:19:03 PDT 
Created attachment 203580 [details]
Patch
Comment 2 Grzegorz Czajkowski 2013-06-03 06:43:03 PDT 
Comment on attachment 203580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203580&action=review

> LayoutTests/ChangeLog:8
> +        Unskipping accessibility/placeholder.html after r151103.

Nit: do you mind changing it to "Remove a test failure as it started passing after r151103"?
This tests is marked as failing, as a result it's running. "Unskipping" may be confused for test that are not skipped.
Comment 3 Krzysztof Czech 2013-06-03 06:55:11 PDT 
(In reply to comment #2)
> (From update of attachment 203580 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203580&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        Unskipping accessibility/placeholder.html after r151103.
> 
> Nit: do you mind changing it to "Remove a test failure as it started passing after r151103"?
> This tests is marked as failing, as a result it's running. "Unskipping" may be confused for test that are not skipped.

Good nit.
Comment 4 Krzysztof Czech 2013-06-03 06:55:54 PDT 
Created attachment 203585 [details]
Patch
Comment 5 WebKit Commit Bot 2013-06-03 07:26:24 PDT 
Comment on attachment 203585 [details]
Patch

Clearing flags on attachment: 203585

Committed r151112: <http://trac.webkit.org/changeset/151112>
Comment 6 WebKit Commit Bot 2013-06-03 07:26:26 PDT 
All reviewed patches have been landed.  Closing bug.