Bug 112001 - [EFL] accessibility/ignore-spacer-elements.html is failing.
Summary: [EFL] accessibility/ignore-spacer-elements.html is failing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111985
  Show dependency tree / graph
 
Reported: 2013-03-11 07:21 PDT by Krzysztof Czech
Modified: 2013-04-03 02:47 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.40 KB, patch)
2013-03-20 08:12 PDT, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2013-03-11 07:21:57 PDT 
accessibility/ignore-spacer-elements.html is failing on all EFL platforms.
Comment 1 Krzysztof Czech 2013-03-20 08:12:31 PDT 
Created attachment 194063 [details]
Patch
Comment 2 Mario Sanchez Prada 2013-03-21 03:21:45 PDT 
Comment on attachment 194063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194063&action=review

> LayoutTests/accessibility/ignore-spacer-elements.html:28
> +            var expectedCount = (testRunner.platformName == "gtk" || testRunner.platformName == "efl") ? 2 : 4;

I wonder if it would make sense to change DRT to output "atk" for testRunner.platformName both in GTK and EFL ports, to reduce the amount of ORs like this one in layout tests.

Thoughts?
Comment 3 Krzysztof Czech 2013-03-21 04:24:08 PDT 
> I wonder if it would make sense to change DRT to output "atk" for testRunner.platformName both in GTK and EFL ports, to reduce the amount of ORs like this one in layout tests.
> 
> Thoughts?
In terms of accessibility layout tests it sounds good. I'm wondering about other tests and potential differences between platforms.
Comment 4 Mario Sanchez Prada 2013-03-21 06:28:06 PDT 
(In reply to comment #3)
> > I wonder if it would make sense to change DRT to output "atk" for testRunner.platformName both in GTK and EFL ports, to reduce the amount of ORs like this one in layout tests.
> > 
> > Thoughts?
> In terms of accessibility layout tests it sounds good. I'm wondering about other tests and potential differences between platforms.

Ah, yes... you're right. I was thinking of this as an a11y-only feature of DRT, but it's true it's not like that, since is a general feature of testRunner (even though it's only used in a11y tests so far, I think).
Comment 5 Krzysztof Czech 2013-03-28 08:46:22 PDT 
> Ah, yes... you're right. I was thinking of this as an a11y-only feature of DRT, but it's true it's not like that, since is a general feature of testRunner (even though it's only used in a11y tests so far, I think).

Yes, it's only used in a11y tests.
Comment 6 Gyuyoung Kim 2013-04-03 01:27:28 PDT 
Comment on attachment 194063 [details]
Patch

rs=me
Comment 7 WebKit Review Bot 2013-04-03 02:47:39 PDT 
Comment on attachment 194063 [details]
Patch

Clearing flags on attachment: 194063

Committed r147534: <http://trac.webkit.org/changeset/147534>
Comment 8 WebKit Review Bot 2013-04-03 02:47:43 PDT 
All reviewed patches have been landed.  Closing bug.