Bug 111995 – [wk2] Search With [your search provider here] should use NSPerformService in WebKit2/Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

So that the context menu will open a tab in the browser instead of attempting to navigate the main frame, which is the wrong thing to do in some clients.

Also, add support for the same feature to PDFPlugin, since it’s now free.

<rdar://problem/12975669>

[Tim Horton]

Created attachment 192460 [details]
patch

[WebKit Review Bot]

Attachment 192460 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm']" exit_code: 1
Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:82:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Created attachment 192464 [details]
stylebot happiness is good

[WebKit Review Bot]

Comment on attachment 192464 [details]
stylebot happiness is good

Clearing flags on attachment: 192464

Committed r145390: <http://trac.webkit.org/changeset/145390>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.