Bug 111979 – [Qt] Qml WebKit needs preferences to change security knobs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Maxim Ermilov]

Qml WebKit needs preferences to change security knobs

[Maxim Ermilov]

Created attachment 192450 [details]
Patch

[Michael Brüning]

Looks good to me.

[Jocelyn Turcotte]

LGTM
This needs a WebKit2 Owner approval before this can go on.

CCing Benjamin hoping he's not too busy :)

[Jocelyn Turcotte]

CCing Benjamin for real this time.

[Benjamin Poulain]

Comment on attachment 192450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192450&action=review

Why do you need to expose WebSecurityEnabled?

I am not too worried about the two others but a word of explanation for those would be nice.

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:594
> +    d->setAttribute(QWebPreferencesPrivate::UniversalAccessFromFileURLsAllowed, enable);
> +    emit universalAccessFromFileURLsAllowedChanged();

You don't check the original value before emitting the signal?

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:605
> +    d->setAttribute(QWebPreferencesPrivate::FileAccessFromFileURLsAllowed, enable);
> +    emit fileAccessFromFileURLsAllowedChanged();

Ditto.

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:616
> +    d->setAttribute(QWebPreferencesPrivate::WebSecurityEnabled, enable);
> +    emit webSecurityEnabledChanged();

Ditto.

[Maxim Ermilov]

Created attachment 194568 [details]
Patch

[Maxim Ermilov]

> Why do you need to expose WebSecurityEnabled?
I need 2 others, WebSecurityEnabled was added just in case of future needs.
(expose only UniversalAccessFromFileURLsAllowed/FileAccessFromFileURLsAllowed in patch)

> You don't check the original value before emitting the signal?
fixed

[Benjamin Poulain]

Comment on attachment 194568 [details]
Patch

Signed off by me for WebKit2.

[Jocelyn Turcotte]

Comment on attachment 194568 [details]
Patch

(In reply to comment #8)
> (From update of attachment 194568 [details])
> Signed off by me for WebKit2.

r=me (with special thanks to Benjamin for covering my slopiness)

[WebKit Review Bot]

Comment on attachment 194568 [details]
Patch

Clearing flags on attachment: 194568

Committed r146766: <http://trac.webkit.org/changeset/146766>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.