Bug 111979 - [Qt] Qml WebKit needs preferences to change security knobs
Summary: [Qt] Qml WebKit needs preferences to change security knobs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-11 05:44 PDT by Maxim Ermilov
Modified: 2013-03-25 06:56 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.16 KB, patch)
2013-03-11 05:50 PDT, Maxim Ermilov 		no flags Details | Formatted Diff | Diff
Patch (6.40 KB, patch)
2013-03-22 09:29 PDT, Maxim Ermilov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Ermilov 2013-03-11 05:44:51 PDT 
Qml WebKit needs preferences to change security knobs
Comment 1 Maxim Ermilov 2013-03-11 05:50:48 PDT 
Created attachment 192450 [details]
Patch
Comment 2 Michael Brüning 2013-03-20 08:17:42 PDT 
Looks good to me.
Comment 3 Jocelyn Turcotte 2013-03-20 08:26:34 PDT 
LGTM
This needs a WebKit2 Owner approval before this can go on.

CCing Benjamin hoping he's not too busy :)
Comment 4 Jocelyn Turcotte 2013-03-20 08:26:59 PDT 
CCing Benjamin for real this time.
Comment 5 Benjamin Poulain 2013-03-20 14:17:43 PDT 
Comment on attachment 192450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192450&action=review

Why do you need to expose WebSecurityEnabled?

I am not too worried about the two others but a word of explanation for those would be nice.

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:594
> +    d->setAttribute(QWebPreferencesPrivate::UniversalAccessFromFileURLsAllowed, enable);
> +    emit universalAccessFromFileURLsAllowedChanged();

You don't check the original value before emitting the signal?

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:605
> +    d->setAttribute(QWebPreferencesPrivate::FileAccessFromFileURLsAllowed, enable);
> +    emit fileAccessFromFileURLsAllowedChanged();

Ditto.

> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:616
> +    d->setAttribute(QWebPreferencesPrivate::WebSecurityEnabled, enable);
> +    emit webSecurityEnabledChanged();

Ditto.
Comment 6 Maxim Ermilov 2013-03-22 09:29:12 PDT 
Created attachment 194568 [details]
Patch
Comment 7 Maxim Ermilov 2013-03-22 09:32:18 PDT 
> Why do you need to expose WebSecurityEnabled?
I need 2 others, WebSecurityEnabled was added just in case of future needs.
(expose only UniversalAccessFromFileURLsAllowed/FileAccessFromFileURLsAllowed in patch)

> You don't check the original value before emitting the signal?
fixed
Comment 8 Benjamin Poulain 2013-03-22 15:08:13 PDT 
Comment on attachment 194568 [details]
Patch

Signed off by me for WebKit2.
Comment 9 Jocelyn Turcotte 2013-03-25 05:59:30 PDT 
Comment on attachment 194568 [details]
Patch

(In reply to comment #8)
> (From update of attachment 194568 [details])
> Signed off by me for WebKit2.

r=me (with special thanks to Benjamin for covering my slopiness)
Comment 10 WebKit Review Bot 2013-03-25 06:56:40 PDT 
Comment on attachment 194568 [details]
Patch

Clearing flags on attachment: 194568

Committed r146766: <http://trac.webkit.org/changeset/146766>
Comment 11 WebKit Review Bot 2013-03-25 06:56:45 PDT 
All reviewed patches have been landed.  Closing bug.