Bug 111972 - [BlackBerry] SelectionHandler: bring back m_lastSelection attribute
Summary: [BlackBerry] SelectionHandler: bring back m_lastSelection attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency treegraph
 
Reported: 2013-03-11 04:32 PDT by Alberto Garcia
Modified: 2013-03-11 08:35 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.18 KB, patch)
2013-03-11 04:33 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-03-11 04:32:13 PDT
This was removed in r144515 but is still needed by SelectionHandler::selectionPositionChanged()

http://trac.webkit.org/changeset/144515/trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h
Comment 1 Alberto Garcia 2013-03-11 04:33:26 PDT
Created attachment 192438 [details]
Patch
Comment 2 Build Bot 2013-03-11 05:58:49 PDT
Comment on attachment 192438 [details]
Patch

Attachment 192438 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17077829

New failing tests:
fast/css/sticky/sticky-both-sides.html
fast/css/sticky/inline-sticky.html
Comment 3 Rob Buis 2013-03-11 07:33:03 PDT
Comment on attachment 192438 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2013-03-11 08:35:47 PDT
Comment on attachment 192438 [details]
Patch

Clearing flags on attachment: 192438

Committed r145365: <http://trac.webkit.org/changeset/145365>
Comment 5 WebKit Review Bot 2013-03-11 08:35:51 PDT
All reviewed patches have been landed.  Closing bug.