RESOLVED FIXED Bug 111972
[BlackBerry] SelectionHandler: bring back m_lastSelection attribute 
https://bugs.webkit.org/show_bug.cgi?id=111972
Summary [BlackBerry] SelectionHandler: bring back m_lastSelection attribute
Alberto Garcia
Reported 2013-03-11 04:32:13 PDT
This was removed in r144515 but is still needed by SelectionHandler::selectionPositionChanged() http://trac.webkit.org/changeset/144515/trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h
Attachments
Patch (1.18 KB, patch)
2013-03-11 04:33 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-03-11 04:33:26 PDT
Created attachment 192438 [details] Patch
Build Bot
Comment 2 2013-03-11 05:58:49 PDT
Comment on attachment 192438 [details] Patch Attachment 192438 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17077829 New failing tests: fast/css/sticky/sticky-both-sides.html fast/css/sticky/inline-sticky.html
Rob Buis
Comment 3 2013-03-11 07:33:03 PDT
Comment on attachment 192438 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2013-03-11 08:35:47 PDT
Comment on attachment 192438 [details] Patch Clearing flags on attachment: 192438 Committed r145365: <http://trac.webkit.org/changeset/145365>
WebKit Review Bot
Comment 5 2013-03-11 08:35:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.