Bug 111965 - Web Inspector: extract common parts of native profiles
Summary: Web Inspector: extract common parts of native profiles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-11 02:28 PDT by Yury Semikhatsky
Modified: 2013-03-11 05:45 PDT (History)
8 users (show)

See Also:

Attachments
Patch (12.82 KB, patch)
2013-03-11 02:38 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (12.92 KB, patch)
2013-03-11 05:08 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (17.84 KB, patch)
2013-03-11 05:18 PDT, Yury Semikhatsky 		apavlov: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-03-11 02:28:17 PDT 
Most of the profile type logic can be shared between native heap graph profiles and profiles with aggregated statistics. Since we are going to add more details to the aggregated view it makes sense to unify the mechanisms first.
Comment 1 Yury Semikhatsky 2013-03-11 02:38:49 PDT 
Created attachment 192428 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-03-11 02:46:04 PDT 
Comment on attachment 192428 [details]
Patch

lgtm
Comment 3 Yury Semikhatsky 2013-03-11 05:08:40 PDT 
Created attachment 192443 [details]
Patch
Comment 4 Yury Semikhatsky 2013-03-11 05:18:35 PDT 
Created attachment 192445 [details]
Patch
Comment 5 Alexander Pavlov (apavlov) 2013-03-11 05:40:50 PDT 
Comment on attachment 192445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192445&action=review

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:446
> +        var metaInformation = /** @type{HeapSnapshotMetainfo} */(graphMetaInformation);

Whitespace in front of '(' (according to the code I've seen around)

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:585
> +        this.sidebarElement.subtitle = Number.bytesToString(/** @type{number} */(this._memoryBlock.size));

ditto
Comment 6 Yury Semikhatsky 2013-03-11 05:45:24 PDT 
Committed r145357: <http://trac.webkit.org/changeset/145357>