RESOLVED FIXED Bug 111965
Web Inspector: extract common parts of native profiles 
https://bugs.webkit.org/show_bug.cgi?id=111965
Summary Web Inspector: extract common parts of native profiles
Yury Semikhatsky
Reported 2013-03-11 02:28:17 PDT
Most of the profile type logic can be shared between native heap graph profiles and profiles with aggregated statistics. Since we are going to add more details to the aggregated view it makes sense to unify the mechanisms first.
Attachments
Patch (12.82 KB, patch)
2013-03-11 02:38 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (12.92 KB, patch)
2013-03-11 05:08 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (17.84 KB, patch)
2013-03-11 05:18 PDT, Yury Semikhatsky 		apavlov: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2013-03-11 02:38:49 PDT
Created attachment 192428 [details] Patch
Ilya Tikhonovsky
Comment 2 2013-03-11 02:46:04 PDT
Comment on attachment 192428 [details] Patch lgtm
Yury Semikhatsky
Comment 3 2013-03-11 05:08:40 PDT
Created attachment 192443 [details] Patch
Yury Semikhatsky
Comment 4 2013-03-11 05:18:35 PDT
Created attachment 192445 [details] Patch
Alexander Pavlov (apavlov)
Comment 5 2013-03-11 05:40:50 PDT
Comment on attachment 192445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192445&action=review > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:446 > + var metaInformation = /** @type{HeapSnapshotMetainfo} */(graphMetaInformation); Whitespace in front of '(' (according to the code I've seen around) > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:585 > + this.sidebarElement.subtitle = Number.bytesToString(/** @type{number} */(this._memoryBlock.size)); ditto
Yury Semikhatsky
Comment 6 2013-03-11 05:45:24 PDT
Committed r145357: <http://trac.webkit.org/changeset/145357>
Note You need to log in before you can comment on or make changes to this bug.