Bug 111962 - RenderSnapshottedPlugIn paints in PaintPhaseBlockBackground instead of PaintPhaseForeground
Summary: RenderSnapshottedPlugIn paints in PaintPhaseBlockBackground instead of PaintP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-11 01:30 PDT by Tim Horton
Modified: 2013-03-11 01:45 PDT (History)
2 users (show)

See Also:

Attachments
patch (1.60 KB, patch)
2013-03-11 01:32 PDT, Tim Horton 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-03-11 01:30:36 PDT 
This doesn't make sense to me, and breaks with plugins that are display: block'd (http://www.earslap.com/projectslab/otomata).

Plugins normally (see RenderWidget::paint) paint in the foreground phase.

There might be a good reason things are as they are now, so I'd like Dino to review this.

<rdar://problem/13289335>
Comment 1 Tim Horton 2013-03-11 01:32:03 PDT 
Created attachment 192424 [details]
patch
Comment 2 Dean Jackson 2013-03-11 01:43:27 PDT 
Comment on attachment 192424 [details]
patch

Nope - you're right! This explains the disappearing snapshots :)
Comment 3 Tim Horton 2013-03-11 01:45:53 PDT 
Excellent.

http://trac.webkit.org/changeset/145346