Bug 111948 - Coordinated Graphics: Rename client classes for CoordinatedImageBacking and UpdateAtlas.
Summary: Coordinated Graphics: Rename client classes for CoordinatedImageBacking and U...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 111919
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-10 16:46 PDT by Gwang Yoon Hwang
Modified: 2013-06-05 05:06 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.34 KB, patch)
2013-03-10 16:49 PDT, Gwang Yoon Hwang
no flags Details | Formatted Diff | Diff
Patch (10.92 KB, patch)
2013-03-10 23:12 PDT, Gwang Yoon Hwang
no flags Details | Formatted Diff | Diff
Patch (10.83 KB, patch)
2013-06-05 02:58 PDT, Gwang Yoon Hwang
no flags Details | Formatted Diff | Diff
Patch (10.83 KB, patch)
2013-06-05 05:03 PDT, Gwang Yoon Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gwang Yoon Hwang 2013-03-10 16:46:22 PDT
Coordinated Graphics: Rename client classes for CoordinatedImageBacking and UpdateAtlas.
Comment 1 Gwang Yoon Hwang 2013-03-10 16:49:55 PDT
Created attachment 192392 [details]
Patch
Comment 2 Gwang Yoon Hwang 2013-03-10 23:12:17 PDT
Created attachment 192406 [details]
Patch
Comment 3 Noam Rosenthal 2013-03-10 23:58:29 PDT
Comment on attachment 192406 [details]
Patch

LGTM, please ask a WK2 owner for signoff.
Comment 4 Gwang Yoon Hwang 2013-06-05 02:58:58 PDT
Created attachment 203778 [details]
Patch
Comment 5 WebKit Commit Bot 2013-06-05 04:45:57 PDT
Comment on attachment 203778 [details]
Patch

Rejecting attachment 203778 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 203778, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ile Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h
Hunk #1 succeeded at 47 (offset -1 lines).
Hunk #2 succeeded at 110 with fuzz 2 (offset -1 lines).
Hunk #3 FAILED at 126.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Noam Rosenthal']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/701483
Comment 6 Gwang Yoon Hwang 2013-06-05 05:03:34 PDT
Created attachment 203807 [details]
Patch
Comment 7 WebKit Commit Bot 2013-06-05 05:04:50 PDT
Comment on attachment 203778 [details]
Patch

Clearing flags on attachment: 203778

Committed r151214: <http://trac.webkit.org/changeset/151214>
Comment 8 WebKit Commit Bot 2013-06-05 05:04:53 PDT
All reviewed patches have been landed.  Closing bug.