Bug 111944 - XSSAuditor doesn't need a copy of the original document URL.
Summary: XSSAuditor doesn't need a copy of the original document URL.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks: 110733
  Show dependency tree / graph
 
Reported: 2013-03-10 11:47 PDT by Mike West
Modified: 2013-03-10 12:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.50 KB, patch)
2013-03-10 11:57 PDT, Mike West 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2013-03-10 11:47:18 PDT 
XSSAuditor doesn't need a copy of the original document URL.
Comment 1 Mike West 2013-03-10 11:57:30 PDT 
Created attachment 192382 [details]
Patch
Comment 2 Mike West 2013-03-10 11:59:34 PDT 
As Adam noted in https://bugs.webkit.org/show_bug.cgi?id=110733#c36, there doesn't seem to be any good reason to retain a copy of this string.
Comment 3 Adam Barth 2013-03-10 12:45:18 PDT 
Comment on attachment 192382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192382&action=review

> Source/WebCore/html/parser/XSSAuditorDelegate.cpp:76
>          reportDetails->setString("request-body", xssInfo.m_originalHTTPBody);

Is the same true of the request body?
Comment 4 Mike West 2013-03-10 12:51:53 PDT 
(In reply to comment #3)
> (From update of attachment 192382 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192382&action=review
> 
> > Source/WebCore/html/parser/XSSAuditorDelegate.cpp:76
> >          reportDetails->setString("request-body", xssInfo.m_originalHTTPBody);
> 
> Is the same true of the request body?

Looks like it might be; I don't think there's any circumstance in which the document's loader would change, or the loader's originalRequest. I'll put together another patch and see what happens if I just remove that property as well.
Comment 5 WebKit Review Bot 2013-03-10 12:59:18 PDT 
Comment on attachment 192382 [details]
Patch

Clearing flags on attachment: 192382

Committed r145331: <http://trac.webkit.org/changeset/145331>
Comment 6 WebKit Review Bot 2013-03-10 12:59:21 PDT 
All reviewed patches have been landed.  Closing bug.