Bug 111918 - [CSS Grid Layout] Handle spanning grid items over specified grid tracks
Summary: [CSS Grid Layout] Handle spanning grid items over specified grid tracks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 103314
  Show dependency treegraph
 
Reported: 2013-03-08 20:41 PST by Julien Chaffraix
Modified: 2013-03-11 12:10 PDT (History)
7 users (show)

See Also:


Attachments
Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes. (8.96 KB, patch)
2013-03-08 20:51 PST, Julien Chaffraix
no flags Details | Formatted Diff | Diff
Patch for landing (8.93 KB, patch)
2013-03-11 11:48 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2013-03-08 20:41:02 PST
The current code assumes that a grid item only spans one grid track in every direction. Now that we can parse multiple positions and properly resolve them, we can allow spanning grid items to be properly sized after their spanning grid areas.
Comment 1 Julien Chaffraix 2013-03-08 20:51:51 PST
Created attachment 192332 [details]
Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes.
Comment 2 Tony Chang 2013-03-11 10:14:58 PDT
Comment on attachment 192332 [details]
Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes.

View in context: https://bugs.webkit.org/attachment.cgi?id=192332&action=review

> Source/WebCore/rendering/RenderGrid.cpp:750
> +        // We don't support spanning with auto positions yet.

Nit: Should this be a FIXME?
Comment 3 Julien Chaffraix 2013-03-11 11:44:30 PDT
Comment on attachment 192332 [details]
Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes.

View in context: https://bugs.webkit.org/attachment.cgi?id=192332&action=review

>> Source/WebCore/rendering/RenderGrid.cpp:750
>> +        // We don't support spanning with auto positions yet.
> 
> Nit: Should this be a FIXME?

Good point, there is also not a single bug I can't point to as it really depends how much of the <grid-line> grammar we support.
Comment 4 Julien Chaffraix 2013-03-11 11:48:29 PDT
Created attachment 192521 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-03-11 12:10:05 PDT
Comment on attachment 192521 [details]
Patch for landing

Clearing flags on attachment: 192521

Committed r145378: <http://trac.webkit.org/changeset/145378>
Comment 6 WebKit Review Bot 2013-03-11 12:10:08 PDT
All reviewed patches have been landed.  Closing bug.