WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111905
[CA] Animations of CSS filters don't work correctly
https://bugs.webkit.org/show_bug.cgi?id=111905
Summary
[CA] Animations of CSS filters don't work correctly
Simon Fraser (smfr)
Reported
2013-03-08 17:19:31 PST
Transitioning filters to/from filter: none should show a nice smooth progression from no filter to the applied filter. It doesn't; it either jumps, or animates jankily.
Attachments
Testcase
(2.58 KB, text/html)
2013-03-08 20:42 PST
,
Simon Fraser (smfr)
no flags
Details
More complete testcase
(2.80 KB, text/html)
2013-03-08 23:11 PST
,
Simon Fraser (smfr)
no flags
Details
Patch
(81.32 KB, patch)
2013-03-10 23:10 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(81.30 KB, patch)
2013-03-11 08:57 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(81.29 KB, patch)
2013-03-11 10:55 PDT
,
Simon Fraser (smfr)
dino
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-03-08 17:20:21 PST
<
rdar://problem/13383975
>
Dirk Schulze
Comment 2
2013-03-08 19:17:31 PST
What happens with a SVG Filter reference? Do we just snap to another filter after the half of the time?
Simon Fraser (smfr)
Comment 3
2013-03-08 20:42:11 PST
Created
attachment 192331
[details]
Testcase
Simon Fraser (smfr)
Comment 4
2013-03-08 20:57:46 PST
We're adding filters to layers OK: contents (surface 8 [200 200] BGRA8888)) (filters (array (filter colorMonochrome (inputs (array (inputAmount (vector 0.999753058))))))) (animations (array (basic-animation (timing (beginTime 2488.306979) (duration 1.000000) (fillMode forwards) (repeatCount 1.000000)) (timingFunction (vector 0.25 0.1000000015 0.25 1)) (removedOnCompletion false) (keyPath filters.filter_0.inputIntensity) (from (vector 1)) (to (vector 0) but I think the key path is wrong: filters.filter_0.inputIntensity)
Simon Fraser (smfr)
Comment 5
2013-03-08 21:07:20 PST
I think the keyPath should be [filterType]-[index]
Simon Fraser (smfr)
Comment 6
2013-03-08 21:27:12 PST
The filter properties returned by PlatformCAAnimation::animatedFilterPropertyName() are also wrong.
Dean Jackson
Comment 7
2013-03-08 22:34:13 PST
I screwed up when we moved to CAFilters and forgot to change PlatformCAAnimation stuff. Simon is fixing this right now.
Simon Fraser (smfr)
Comment 8
2013-03-08 23:11:41 PST
Created
attachment 192337
[details]
More complete testcase
Simon Fraser (smfr)
Comment 9
2013-03-09 11:22:47 PST
The sepia values for CI filters seem way off, and the matrix we're using doesn't seem to correspond to
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#sepiaEquivalent
Simon Fraser (smfr)
Comment 10
2013-03-09 11:25:57 PST
CI invert seems broken too.
Simon Fraser (smfr)
Comment 11
2013-03-09 11:30:17 PST
CI opacity animations were also broken (need to use a CIVector).
Simon Fraser (smfr)
Comment 12
2013-03-09 11:44:07 PST
And I think we'll have to do brightness in CI as a color matrix. CI does brightness in color adjust by just adding/subtracting the RGB values, which doesn't match the slope/intersect stuff that the spec says.
Dirk Schulze
Comment 13
2013-03-09 21:21:01 PST
(In reply to
comment #12
)
> And I think we'll have to do brightness in CI as a color matrix. CI does brightness in color adjust by just adding/subtracting the RGB values, which doesn't match the slope/intersect stuff that the spec says.
It sounds a bit like "how could that ever work" :P
Simon Fraser (smfr)
Comment 14
2013-03-10 23:10:12 PDT
Created
attachment 192405
[details]
Patch
Simon Fraser (smfr)
Comment 15
2013-03-11 08:57:05 PDT
Created
attachment 192479
[details]
Patch
Build Bot
Comment 16
2013-03-11 10:13:43 PDT
Comment on
attachment 192479
[details]
Patch
Attachment 192479
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-commit-queue.appspot.com/results/17121240
Simon Fraser (smfr)
Comment 17
2013-03-11 10:55:05 PDT
Created
attachment 192506
[details]
Patch
Dean Jackson
Comment 18
2013-03-11 14:12:23 PDT
Comment on
attachment 192506
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=192506&action=review
> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:387 > + NSLog(@"Adding animation %@ for key %@", propertyAnimation, (NSString*)key);
Oops.
Simon Fraser (smfr)
Comment 19
2013-03-12 10:57:54 PDT
http://trac.webkit.org/changeset/145472
and followups
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug