[CA] Animations of CSS filters don't work correctly

[Simon Fraser (smfr)]

Transitioning filters to/from filter: none should show a nice smooth progression from no filter to the applied filter. It doesn't; it either jumps, or animates jankily.

[Radar WebKit Bug Importer]

<rdar://problem/13383975>

[Dirk Schulze]

What happens with a SVG Filter reference? Do we just snap to another filter after the half of the time?

[Simon Fraser (smfr)]

Created attachment 192331 [details]
Testcase

[Simon Fraser (smfr)]

We're adding filters to layers OK:
contents (surface 8 [200 200] BGRA8888))
                                                          (filters (array
                                                            (filter colorMonochrome
                                                              (inputs (array
                                                                (inputAmount (vector 0.999753058)))))))
                                                          (animations (array
                                                            (basic-animation
                                                              (timing
                                                                (beginTime 2488.306979)
                                                                (duration 1.000000)
                                                                (fillMode forwards)
                                                                (repeatCount 1.000000))
                                                              (timingFunction (vector 0.25 0.1000000015 0.25 1))
                                                              (removedOnCompletion false)
                                                              (keyPath filters.filter_0.inputIntensity)
                                                              (from (vector 1))
                                                              (to (vector 0)

but I think the key path is wrong:  filters.filter_0.inputIntensity)

[Simon Fraser (smfr)]

I think the keyPath should be [filterType]-[index]

[Simon Fraser (smfr)]

The filter properties returned by PlatformCAAnimation::animatedFilterPropertyName() are also wrong.

[Dean Jackson]

I screwed up when we moved to CAFilters and forgot to change PlatformCAAnimation stuff. Simon is fixing this right now.

[Simon Fraser (smfr)]

Created attachment 192337 [details]
More complete testcase

[Simon Fraser (smfr)]

The sepia values for CI filters seem way off, and the matrix we're using doesn't seem to correspond to https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#sepiaEquivalent

[Simon Fraser (smfr)]

CI invert seems broken too.

[Simon Fraser (smfr)]

CI opacity animations were also broken (need to use a CIVector).

[Simon Fraser (smfr)]

And I think we'll have to do brightness in CI as a color matrix. CI does brightness in color adjust by just adding/subtracting the RGB values, which doesn't match the slope/intersect stuff that the spec says.

[Dirk Schulze]

(In reply to comment #12)
> And I think we'll have to do brightness in CI as a color matrix. CI does brightness in color adjust by just adding/subtracting the RGB values, which doesn't match the slope/intersect stuff that the spec says.

It sounds a bit like "how could that ever work" :P

[Simon Fraser (smfr)]

Created attachment 192405 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 192479 [details]
Patch

[Build Bot]

Comment on attachment 192479 [details]
Patch

Attachment 192479 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17121240

[Simon Fraser (smfr)]

Created attachment 192506 [details]
Patch

[Dean Jackson]

Comment on attachment 192506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192506&action=review

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:387
> +    NSLog(@"Adding animation %@ for key %@", propertyAnimation, (NSString*)key);

Oops.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/145472 and followups