Transitioning filters to/from filter: none should show a nice smooth progression from no filter to the applied filter. It doesn't; it either jumps, or animates jankily.
What happens with a SVG Filter reference? Do we just snap to another filter after the half of the time?
Created attachment 192331 [details]
We're adding filters to layers OK:
contents (surface 8 [200 200] BGRA8888))
(inputAmount (vector 0.999753058)))))))
(timingFunction (vector 0.25 0.1000000015 0.25 1))
(from (vector 1))
(to (vector 0)
but I think the key path is wrong: filters.filter_0.inputIntensity)
I think the keyPath should be [filterType]-[index]
The filter properties returned by PlatformCAAnimation::animatedFilterPropertyName() are also wrong.
I screwed up when we moved to CAFilters and forgot to change PlatformCAAnimation stuff. Simon is fixing this right now.
Created attachment 192337 [details]
More complete testcase
The sepia values for CI filters seem way off, and the matrix we're using doesn't seem to correspond to https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#sepiaEquivalent
CI invert seems broken too.
CI opacity animations were also broken (need to use a CIVector).
And I think we'll have to do brightness in CI as a color matrix. CI does brightness in color adjust by just adding/subtracting the RGB values, which doesn't match the slope/intersect stuff that the spec says.
(In reply to comment #12)
> And I think we'll have to do brightness in CI as a color matrix. CI does brightness in color adjust by just adding/subtracting the RGB values, which doesn't match the slope/intersect stuff that the spec says.
It sounds a bit like "how could that ever work" :P
Created attachment 192405 [details]
Created attachment 192479 [details]
Comment on attachment 192479 [details]
Attachment 192479 [details] did not pass mac-wk2-ews (mac-wk2):
Created attachment 192506 [details]
Comment on attachment 192506 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=192506&action=review
> + NSLog(@"Adding animation %@ for key %@", propertyAnimation, (NSString*)key);
http://trac.webkit.org/changeset/145472 and followups